x/cli/app.go: proper provider ordering#26
Merged
Merged
Conversation
Member
|
Do we want to? Usually, ENV is used to override flags and args when the tool is running in the cluster/container |
AlexisMontagne
approved these changes
Apr 23, 2026
Contributor
Author
The problem is that this is making our life difficult in github actions where the github-provided envs overloads flags 🫠 IMO the more prioritized ones should be the one that we have the most explicit controls on, ie.e the command interface |
Sypheos
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The value of the last provider is kept: we want args > flags > env
Fixes #
What are the observable changes?
Good PR checklist
Additional Notes