Skip to content

x/cli/app.go: proper provider ordering #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xgoffin merged 2 commits into from
Apr 23, 2026
Merged

x/cli/app.go: proper provider ordering #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0c8d62
x/cli/app.go: proper provider ordering
xgoffin Apr 23, 2026
89fa94a
.github/workflows/lint.yml: bump ubuntu and action versions
xgoffin Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ on: [pull_request]
jobs:
lint:
name: runner / golangci-lint
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04
timeout-minutes: 30
steps:
- name: Install go
uses: actions/setup-go@v4
uses: actions/setup-go@v6
with:
go-version: 'v1.20'
go-version: 'v1.24'
- name: Check out code
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: golanci-lint
uses: upfluence/action-golangci-lint@master
with:
Expand Down
5 changes: 3 additions & 2 deletions x/cli/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,9 @@
cmds, flags = a.parseArgs()
args = make(map[string]string)
ps = append(
[]provider.Provider{pflags.NewProvider(flags), argProvider(args)},
a.ps...,
a.ps,
pflags.NewProvider(flags),
argProvider(args),
)
)

Expand Down Expand Up @@ -134,7 +135,7 @@
if err := a.cmd.Run(ctx, a.commandContext()); err != nil {
code = 1

switch serr := err.(type) {

Check failure on line 138 in x/cli/app.go

View workflow job for this annotation

GitHub Actions / runner / golangci-lint 

type switch on error will fail on wrapped errors. Use errors.As to check for specific errors (errorlint)
case *exec.ExitError:
os.Exit(serr.ExitCode())
case interface{ StatusCode() int }:
Expand Down
Loading