Potential fix for code scanning alert no. 29: Log injection#114
Closed
utsavjosh1 wants to merge 1 commit into
Closed
Potential fix for code scanning alert no. 29: Log injection#114utsavjosh1 wants to merge 1 commit into
utsavjosh1 wants to merge 1 commit into
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/utsavjosh1/Postly/security/code-scanning/29
Best fix: stop logging dynamic error messages that may include user input in this path, and log a constant message (optionally with safe internal context that is not user-controlled).
In
apps/api/src/services/resume.service.ts, update thecatchblock inprocessResumesoconsole.errorno longer includeserror.message(sanitized or not). Keep behavior unchanged for users by still returningresume. This preserves functionality while removing tainted data from logs entirely.No new imports or dependencies are needed.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.