Skip to content

Potential fix for code scanning alert no. 29: Log injection #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
utsavjosh1 wants to merge 1 commit into from
Closed

Potential fix for code scanning alert no. 29: Log injection #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions apps/api/src/services/resume.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,14 +152,9 @@
);

return updatedResume || resume;
} catch (error) {
// Safe error logging to avoid log injection
console.error(
"Error processing resume:",
error instanceof Error
? this.sanitizeForLog(error.message)
: "Unknown error",
);
} catch (_error) {

Check failure on line 155 in apps/api/src/services/resume.service.ts

View workflow job for this annotation

GitHub Actions / CI Pipeline 

'_error' is defined but never used
// Avoid logging user-influenced error content to prevent log injection
console.error("Error processing resume");
// The user can retry analysis later
return resume;
}
Expand Down
Loading