docs(tests): retarget stale ADR-0012 ref to ADR-0019#116
Merged
Conversation
Cleanup miss from PR #113 (`ce0d263`): the parity-regression test added in that PR referenced `ADR-0012` for the roadflared/Universal-Links routing pattern, but the ADR was renumbered to `ADR-0019` in PR #112 (`7c08ac8`) while #113 was in flight. The squash merge auto-resolved existing `ADR-0012` references in this file via 3-way merge, but couldn't catch a brand-new line added on the branch. `decisions/0012-coordinator-ride-identity-cache.md` is now an unrelated ADR, so the stale ref doesn't just point at the wrong number — it points at the wrong subject. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line cleanup miss from PR #113.
Context
While PR #113 (Universal Links) was in flight, PR #112 renumbered the roadflared scheme ADR from
0012→0019(commit `7c08ac8` — `docs(adr): retarget Swift "See ADR-0012" refs to ADR-0019`). The squash merge of #113 onto main correctly auto-resolved existing `ADR-0012` references in HandleIncomingURLTests.swift and AppState.swift via 3-way merge — but couldn't catch a brand-new line added on the #113 branch:This isn't just a stale number — `decisions/0012-coordinator-ride-identity-cache.md` is now an unrelated ADR after the renumbering, so the reference points to the wrong subject.
Diff
```diff
```
One file, one line changed.
Verification
`HandleIncomingURLTests` target: 12 tests, 0 failures (comment-only change, no logic touched).
🤖 Generated with Claude Code