Drhuffman12/upgrade to crystal 1.1.1 (and 1.2.0-dev) (#1) and expand CouchDB version checks#2
Open
drhuffman12 wants to merge 2 commits intovectorselector:masterfrom
Open
Drhuffman12/upgrade to crystal 1.1.1 (and 1.2.0-dev) (#1) and expand CouchDB version checks#2drhuffman12 wants to merge 2 commits intovectorselector:masterfrom
drhuffman12 wants to merge 2 commits intovectorselector:masterfrom
Conversation
* drhuffman12/upgrade_to_crystal_1.1.1 "json_mapping" is now a shard (crystal-lang/crystal#9527); (Refactor to use JSON::Serializable instead?) * drhuffman12/upgrade_to_crystal_1.1.1 avoid "Missing ENV key" errors; add more db conn env var's * drhuffman12/upgrade_to_crystal_1.1.1 TODO: Why "CouchDB::Response::Vendor#version" not getting parsed in? * drhuffman12/upgrade_to_crystal_1.1.1 Allow CouchDB '3.x.x' (not just '2.x.x'). (TODO: Add applicable tests for '3.x.x' changes.); TODO: Why "CouchDB::Response::Vendor#version" not getting parsed in? * drhuffman12/upgrade_to_crystal_1.1.1 Bump shard version to "0.4.0"; comment out Crystal version requirement (note compatibility elsewhere?) * drhuffman12/upgrade_to_crystal_1.1.1 cleanup re `Vendor#version` * drhuffman12/upgrade_to_crystal_1.1.1 Add myself as a contributor.
Author
|
Hi @vectorselector / @TechMagister, Thanks for all the groundwork on this shard! Please review these changes. I got the tests to pass for use with:
I'm kinda new to CouchDB. I looked at it years ago and am finally circling back to it. So, Next I'll be reading/reviewing CouchDB tutorials and testing/making an example Crystal-based app with CouchDB. |
This was referenced Sep 6, 2021
* drhuffman12/ci_matrix initial prep * drhuffman12/ci_matrix Copy Github CI w/ matrix re multiple Crystal versions. TODO: edit to include multiple CouchDB versions (or at least one 'latest') * drhuffman12/ci_matrix Copy over "scripts/regen_docs". * drhuffman12/ci_matrix Add 'docs' folder. * drhuffman12/ci_matrix Expand tests for "CouchDB::VERSION" * drhuffman12/ci_matrix Re-gen doc's and add to repo. * drhuffman12/ci_matrix Matrix-ize CouchDB 2 vs 3 checks in CircleCI * drhuffman12/ci_matrix Disable Github Workflows/Actions; trying CircleCI matrix instead. * drhuffman12/ci_matrix remove github workflow related files (no longer needed)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-[x] Add dependency of
crystal-lang/json_mapping.cr/ (JSON.mappingwas deprecated and moved to shard.)-[x] Add more environment variables for database connection settings with defaults.
-[x] DEPRECATION: Use
ServerInfo#versioninstead ofVendor#version.As of v3.x (or earlier?), a call to the server's root (e.g.:
GET http://127.0.0.1:5984/)no longer returns
versioninsidevendor.In v3.x, response will instead look like (as of v3.1.1):
-[x] Allow
3.x.xversions of CouchDB.is_v2?andis_v3?methods toCouchDB::Response::ServerInfo.3.x.xand via CircleCI w/2.x.x-[x] Remove hard-coded
crystalkey/version fromshard.yml(for now).Crystal 1.1.1 [6d9a1d583] (2021-07-26)Crystal 1.2.0-dev [cadc4b3c7] (2021-09-02)-[x] Bump version of this shard to
0.4.0CouchDB::VERSIONbased on shard version value in fromshard.yml(to avoid out-of-sync issues).drhuffman12/ci_matrix CouchDB (2.x? and 3.x?)(#2) adds CI test runs for matrix CouchDB (2.x? and 3.x?):