fix(embed): default missing warnings to [] for v2 embedding models - #14933
Closed
SAY-5 wants to merge 1 commit into
Closed
fix(embed): default missing warnings to [] for v2 embedding models#14933SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: SAY-5 <say.apm35@gmail.com>
aayush-kapoor
left a comment
aayush-kapoor
left a comment
Collaborator
There was a problem hiding this comment.
marking closed in favour of #15324
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14926.
EmbeddingModelV2providers may omitwarningsfromdoEmbed. Three sites inpackages/ai/src/embedpropagatedmodelResponse.warningsdirectly into the result; downstreamlogWarningsreads.lengthandembed-many's chunked path spreads...result.warnings, both crash on undefined. Coerce with?? []at each boundary, and add a regression test usingMockEmbeddingModelV2with nowarningsfield.