Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/ai/src/embed/embed-many.ts
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ export async function embedMany({
return {
embeddings,
usage,
warnings: modelResponse.warnings,
warnings: modelResponse.warnings ?? [],
providerMetadata: modelResponse.providerMetadata,
response: modelResponse.response,
};
Expand Down Expand Up @@ -317,7 +317,7 @@ export async function embedMany({
return {
embeddings: chunkEmbeddings,
usage,
warnings: modelResponse.warnings,
warnings: modelResponse.warnings ?? [],
providerMetadata: modelResponse.providerMetadata,
response: modelResponse.response,
};
Expand Down
20 changes: 20 additions & 0 deletions packages/ai/src/embed/embed.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,26 @@ describe('result.warnings', () => {

expect(result.warnings).toStrictEqual(expectedWarnings);
});

it('defaults warnings to [] when the model omits them (v2 shape)', async () => {
// Regression for #14926: EmbeddingModelV2 implementations may omit
// `warnings`; embed() previously propagated `undefined` and crashed
// downstream in logWarnings.
const { MockEmbeddingModelV2 } = await import(
'../test/mock-embedding-model-v2'
);
const result = await embed({
model: new MockEmbeddingModelV2<string>({
doEmbed: async () => ({
embeddings: [dummyEmbedding],
// intentionally no `warnings` field
}),
}),
value: testValue,
});

expect(result.warnings).toStrictEqual([]);
});
});

describe('logWarnings', () => {
Expand Down
4 changes: 3 additions & 1 deletion packages/ai/src/embed/embed.ts
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,9 @@ export async function embed({
return {
embedding,
usage,
warnings: modelResponse.warnings,
// EmbeddingModelV2 implementations may omit `warnings`; default to []
// so logWarnings and downstream consumers don't crash on undefined.
warnings: modelResponse.warnings ?? [],
providerMetadata: modelResponse.providerMetadata,
response: modelResponse.response,
};
Expand Down