fix(ai): default missing embedding warnings#15324
Merged
aayush-kapoor merged 1 commit intoMay 15, 2026
Merged
Conversation
This comment was marked as spam.
This comment was marked as spam.
aayush-kapoor
approved these changes
May 15, 2026
aayush-kapoor
added
the
backport
github-actions
Bot
removed
the
backport
Contributor
|
|
Contributor
|
🚀 Published in:
|
aayush-kapoor
added a commit
that referenced
this pull request
May 15, 2026
This is an automated backport of #15324 to the release-v6.0 branch. FYI @Kage18 This backport has conflicts that need to be resolved manually. ### `git cherry-pick` output ``` Auto-merging packages/ai/src/embed/embed-many.test.ts CONFLICT (content): Merge conflict in packages/ai/src/embed/embed-many.test.ts Auto-merging packages/ai/src/embed/embed-many.ts CONFLICT (content): Merge conflict in packages/ai/src/embed/embed-many.ts Auto-merging packages/ai/src/embed/embed.test.ts CONFLICT (content): Merge conflict in packages/ai/src/embed/embed.test.ts Auto-merging packages/ai/src/embed/embed.ts CONFLICT (content): Merge conflict in packages/ai/src/embed/embed.ts error: could not apply e3a0419... fix(ai): default missing embedding warnings (#15324) hint: After resolving the conflicts, mark them with hint: "git add/rm <pathspec>", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". hint: Disable this message with "git config set advice.mergeConflict false" ``` --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Aayush Kapoor <aayushkapoor34@gmail.com> Co-authored-by: Aayush Kapoor <83492835+aayush-kapoor@users.noreply.github.com>
gr2m
pushed a commit
that referenced
this pull request
Jun 5, 2026
## Summary Fixes #14926. EmbeddingModelV2 providers can return doEmbed results without a warnings field. embed() and embedMany() currently forward that missing value into result/logging paths that expect an array, which can crash at runtime. This defaults missing embedding warnings to [] at the embed boundary for: - embed() - embedMany() single-call path - embedMany() chunked path ## Tests - pnpm --dir packages/ai exec vitest --config vitest.node.config.js --run src/embed/embed.test.ts src/embed/embed-many.test.ts - pnpm --dir packages/ai exec vitest --config vitest.edge.config.js --run src/embed/embed.test.ts src/embed/embed-many.test.ts - pnpm --filter ai type-check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14926.
EmbeddingModelV2 providers can return doEmbed results without a warnings field. embed() and embedMany() currently forward that missing value into result/logging paths that expect an array, which can crash at runtime.
This defaults missing embedding warnings to [] at the embed boundary for:
Tests