Under annotations

[hflexgrig]

Here in this pr I'll try to bring under annotations ( \underbrace, \underbracket ) with display and latex support

[hflexgrig]

@Happypig375 Implementation might take a few days, especially display part is a quite complicated, on a Mathify I've spent more then week :) I'll do a small commits, please track all my commits for better quality and quick fixes.

[hflexgrig]

@Happypig375 Just ran the dotnet format command on a core CSharpMath.csproj , and it broght changes on 53 files, similar to what it changed that you commented already. Lats first resolve problem with autoformatting. I'm using vs code ide, which ide do you use and which formatters? don't want to bring lots of formatting changes on my pr

[Happypig375]

@hflexgrig I just use Visual Studio and it formats things on the fly. You can pull request all the auto formatting. The unnecessary space should be fixed though.

[hflexgrig]

Almost...

[hflexgrig]

@Happypig375 I think finished with basic implementation, lats fixup this one and merge, then adding rest of the annotations would be much easier! this was the most difficult part.

[Happypig375]

@hflexgrig Tell me when you let me take this PR over

[hflexgrig]

@hflexgrig Tell me when you let me take this PR over

I think we can merge it now, if no additional fixups required from your side

[Happypig375]

There is at least a big red cross that needs fixing. Also, your NotImplementedException which prevents Display tests from being added.

[hflexgrig]

There is at least a big red cross that needs fixing. Also, your NotImplementedException which prevents Display tests from being added.

Hmm... running dotnet format --exclude Typography breaking the unittests.

dotnet format --exclude Typography Warnings were encountered while loading the workspace. Set the verbosity option to the 'diagnostic' level to log warnings. Unable to fix CA1416. No associated code fix found. Unable to fix AVP1001. No associated code fix found.

[Happypig375]

@hflexgrig It does that when encountering any warning. Warnings are disregarded by the format check for now.

[Happypig375]

I can commit some tests when you're done with committing.

[hflexgrig]

I can commit some tests when you're done with committing.

Yes please, go ahead

[Happypig375]

Hmm, it appears that dotnet format --exclude Typography --verbosity diagnostic always outputs the following 2 lines for me on Mac:

Formatted code file '/Users/happypig375/source/repos/CSharpMath/CSharpMath.Xaml/Views.cs'.
Formatted code file '/Users/happypig375/source/repos/CSharpMath/CSharpMath.Maui.Example/MauiProgram.cs'.

Is this a Unix vs Windows issue?

[Happypig375]

I suspect this is a CRLF and LF line ending issue.

[Happypig375]

See #250 PR on this PR - hflexgrig#1

[hflexgrig]

See #250 PR on this PR - hflexgrig#1

That one could be merged into master, and then master into my branch, so that pr changes are clear.