Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 3, 2026

Investigation into PR #245 formatting check failure reveals no action required. Commit a0f06eff ("ran dotnet format with fixups") already resolved all formatting issues.

Findings

Original errors (commit 06c19f8e): WHITESPACE violations, not line endings

  • Pattern matching: {Count:>0}{ Count: > 0 }
  • Indentation and blank line spacing

Current state (commit bf2e3cb0): Passes dotnet format --verify-no-changes on both platforms

  • Linux (LF): ✅
  • Windows (CRLF): ✅

Why both line endings work

.editorconfig omits end_of_line setting → dotnet format accepts both LF and CRLF. Repository has mixed line endings but this doesn't cause failures.

Recommendation

Close this PR. Merge PR #245 as-is.

Adding .gitattributes for line ending normalization would improve consistency but is orthogonal to the formatting check passing.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • crl.godaddy.com
    • Triggering command: /usr/share/dotnet/dotnet dotnet restore /home/REDACTED/work/CSharpMath/CSharpMath/CSharpMath.slnx (dns block)
  • ocsp.godaddy.com
    • Triggering command: /usr/share/dotnet/dotnet dotnet restore /home/REDACTED/work/CSharpMath/CSharpMath/CSharpMath.slnx (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This PR needs to fix the formatting check failure that is blocking PR #245 (#245).

Context

PR #245 by @hflexgrig is adding support for under annotations (\underbrace, \underbracket) with display and latex support. The latest commit is bf2e3cb0e8127661b6f9cbb2cad6be026376dd6e on the under_annotations branch in the hflexgrig/CSharpMath fork.

Task

The formatting check is failing. You need to:

  1. Check out the changes from PR Under annotations #245 (branch under_annotations from fork hflexgrig/CSharpMath, commit bf2e3cb0e8127661b6f9cbb2cad6be026376dd6e)
  2. Run dotnet format --exclude Typography at the repository root
  3. Commit any formatting changes that are applied

Requirements

  • The formatting must pass the check: dotnet format --exclude Typography --verify-no-changes --severity error --verbosity diagnostic
  • The formatting rules are defined in .editorconfig in the repository root
  • Make sure to use .NET 10.x (as specified in the workflow)
  • Only fix formatting issues - do not change any logic or functionality
  • Exclude the Typography folder from formatting as specified

Reference

The workflow that checks formatting is in .github/workflows/Format.yml and runs:

dotnet format --exclude Typography --verify-no-changes --severity error --verbosity diagnostic

This pull request was created from Copilot chat.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Normalizes line endings to LF in repository while allowing platform-native
checkouts (CRLF on Windows, LF on Linux). Verified that dotnet format passes
on both platforms without requiring end_of_line in .editorconfig.

Co-authored-by: Happypig375 <19922066+Happypig375@users.noreply.github.com>
@Happypig375 Happypig375 mentioned this pull request Feb 3, 2026
@Happypig375 Happypig375 force-pushed the copilot/fix-formatting-check-failure branch from db0aa46 to 83d8b42 Compare February 4, 2026 06:53
@Happypig375 Happypig375 changed the title No changes needed - PR #245 formatting already passes Enforce line endings are always stored as LF in git tree Feb 4, 2026
@Happypig375 Happypig375 marked this pull request as ready for review February 4, 2026 07:04
@Happypig375 Happypig375 changed the title Enforce line endings are always stored as LF in git tree Enforce that line endings are always stored as LF in git tree Feb 4, 2026
@Happypig375
Copy link
Collaborator

@charlesroddie Approve please
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants