Skip to content

fix(extensions): MaskExtension compatilble with TerrainExtension#10187

Open
felixpalmer wants to merge 7 commits intomasterfrom
felix/mask-with-terrain
Open

fix(extensions): MaskExtension compatilble with TerrainExtension#10187
felixpalmer wants to merge 7 commits intomasterfrom
felix/mask-with-terrain

Conversation

@felixpalmer
Copy link
Copy Markdown
Collaborator

@felixpalmer felixpalmer commented Apr 7, 2026

Background

Currently if the MaskExtension is used with TerrainExtension no draped layer is drawn. This PR fixes that:

Screenshot 2026-04-07 at 16 02 11

@Pessimistress a change here might want to consider across the board is moving dummyTexture creation. I've tested this pattern this for other effects/extensions and it works - but will leave it for a follow-up PR if you're happy with the approach here

Change List

  • Do not hardcode effects: [] in TerrainPass to allow MaskEffect configuration through
  • Prevent TerrainEffect from including itself after effects: [] removal
  • Move dummy texture creation outside of TerrainEffect instead reference global instance

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 81.443% (+0.008%) from 81.435% — felix/mask-with-terrain into master

@felixpalmer felixpalmer added this to the v9.3 milestone Apr 8, 2026
*
* Created during LayerManager initialization, before any layers or effects set up.
*/
export const dummyTexture = {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would execute extreme caution when using any singleton involving GPU resources. There could be multiple Deck instances on the same page, each using their own device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants