Skip to content

4D PCA-ARSDI: reference cube now properly passed when source_xy is given#713

Open
IainHammond wants to merge 1 commit intovortex-exoplanet:masterfrom
IainHammond:master
Open

4D PCA-ARSDI: reference cube now properly passed when source_xy is given#713
IainHammond wants to merge 1 commit intovortex-exoplanet:masterfrom
IainHammond:master

Conversation

@IainHammond
Copy link
Copy Markdown
Contributor

As title: this one was overlooked by me. I also added a small memory improvement (res_ifs_adi didn't need a wavelength axis)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.32%. Comparing base (6f333b0) to head (67137a0).
⚠️ Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
src/vip_hci/psfsub/pca_fullfr.py 50.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
+ Coverage   50.28%   50.32%   +0.04%     
==========================================
  Files          88       88              
  Lines       17058    17058              
==========================================
+ Hits         8577     8585       +8     
+ Misses       8481     8473       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IainHammond
Copy link
Copy Markdown
Contributor Author

IainHammond commented Apr 16, 2026

Test 3.13.2 is fine, sometimes the data download fails but it was probably because I was running the test on my fork too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants