4D PCA-ARSDI: reference cube now properly passed when source_xy is given#713
Open
IainHammond wants to merge 1 commit intovortex-exoplanet:masterfrom
Open
4D PCA-ARSDI: reference cube now properly passed when source_xy is given#713IainHammond wants to merge 1 commit intovortex-exoplanet:masterfrom
IainHammond wants to merge 1 commit intovortex-exoplanet:masterfrom
Conversation
…ven + small memory improvement
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #713 +/- ##
==========================================
+ Coverage 50.28% 50.32% +0.04%
==========================================
Files 88 88
Lines 17058 17058
==========================================
+ Hits 8577 8585 +8
+ Misses 8481 8473 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Test 3.13.2 is fine, sometimes the data download fails but it was probably because I was running the test on my fork too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title: this one was overlooked by me. I also added a small memory improvement (
res_ifs_adididn't need a wavelength axis)