Skip to content

4D PCA-ARSDI: reference cube now properly passed when source_xy is given #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IainHammond wants to merge 1 commit into
base: master
Choose a base branch
from
Open

4D PCA-ARSDI: reference cube now properly passed when source_xy is given #713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/vip_hci/psfsub/pca_fullfr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1418,7 +1418,7 @@ def _adimsdi_doublepca(
ann_center = dist(yc, xc, y1, x1)
pa_thr = _compute_pa_thresh(ann_center, fwhm, delta_rot)

res_ifs_adi = np.zeros_like(res_cube_channels)
res_ifs_adi = np.zeros((n, y_in, x_in))
max_fr = max_frames_pca
if max_frames_pca is not None:
truncate = True
Expand All @@ -1431,7 +1431,7 @@ def _adimsdi_doublepca(
if 'A' in ref_strategy or cube_ref is None:
res_result = _project_subtract(
res_cube_channels[:n],
None,
res_cube_channels[n:] if nr else None, # ARSDI with rotation threshold, else ASDI
ncomp_adi,
scaling[1],
mask_center_px,
Expand Down Expand Up @@ -1464,7 +1464,7 @@ def _adimsdi_doublepca(

if verbose:
print("De-rotating and combining residuals")
residuals_cube_channels_ = cube_derotate(res_ifs_adi[:n], angle_list,
residuals_cube_channels_ = cube_derotate(res_ifs_adi, angle_list,
nproc=nproc, imlib=imlib,
interpolation=interpolation,
**rot_options)
Expand Down
Loading