mbedtls: handle WSAEWOULDBLOCK in net_send on Windows#3619
Open
saghul wants to merge 1 commit into
Open
Conversation
On Windows LWS_ERRNO is WSAGetLastError(), so a full socket send buffer reports WSAEWOULDBLOCK (10035), not the CRT EWOULDBLOCK. lws_plat_mbedtls_net_send only matched EAGAIN/EWOULDBLOCK, so a backed-up send (e.g. a large HTTP/2 request body upload, where the loopback/peer send buffer fills) was misreported as a fatal MBEDTLS_ERR_NET_SEND_FAILED rather than a retryable WANT_WRITE, tearing down the connection. The sibling lws_plat_mbedtls_net_recv already checks WSAEWOULDBLOCK; mirror it in net_send.
|
lws-team
force-pushed
the
main
branch
5 times, most recently
from
6eecf5a to
b4b5aed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows LWS_ERRNO is WSAGetLastError(), so a full socket send buffer
reports WSAEWOULDBLOCK (10035), not the CRT EWOULDBLOCK. lws_plat_mbedtls_net_send
only matched EAGAIN/EWOULDBLOCK, so a backed-up send (e.g. a large HTTP/2 request
body upload, where the loopback/peer send buffer fills) was misreported as a fatal
MBEDTLS_ERR_NET_SEND_FAILED rather than a retryable WANT_WRITE, tearing down the
connection. The sibling lws_plat_mbedtls_net_recv already checks WSAEWOULDBLOCK;
mirror it in net_send.