Skip to content

mbedtls: handle WSAEWOULDBLOCK in net_send on Windows #3619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saghul wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

mbedtls: handle WSAEWOULDBLOCK in net_send on Windows #3619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/plat/windows/windows-sockets.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,15 @@ lws_plat_mbedtls_net_send(void *ctx, const uint8_t *buf, size_t len)
return ret;

en = LWS_ERRNO;
if (en == EAGAIN || en == EWOULDBLOCK)
/*
* On Windows LWS_ERRNO is WSAGetLastError(), so a full socket send
* buffer reports WSAEWOULDBLOCK, not the CRT EWOULDBLOCK. Without
* matching it here a backed-up send (e.g. a large HTTP/2 upload) is
* misreported as a fatal MBEDTLS_ERR_NET_SEND_FAILED instead of a
* retryable want-write, killing the connection. net_recv() below
* already handles WSAEWOULDBLOCK; mirror it.
*/
if (en == EAGAIN || en == EWOULDBLOCK || en == WSAEWOULDBLOCK)
return MBEDTLS_ERR_SSL_WANT_WRITE;

ret = WSAGetLastError();
Expand Down
Loading