Platform API: Use DatabaseTransactions instead of deleting all users #1048
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaning up from tests with `User::query()->delete();` is a bad idea as it will delete all users rather than just the ones created in `CheckUserEmailExistTest`. Use Laravel's `DatabaseTransactions` trait instead that wraps each test case in a database transaction and only reverts database modifications cause by the test. Bug: T415636
outdooracorn
force-pushed
the
use-database-transactions-trait
branch
from
bbf30bc to
26563fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up from tests with
User::query()->delete();has the negative side effect of deleting all users, rather than just the ones created inCheckUserEmailExistTest.Use Laravel's
DatabaseTransactionstrait instead that wraps each test case in a database transaction and only reverts database modifications caused by the test.Bug: T415636