Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
How to use the Graphite Merge QueueAdd the label main-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Add anton/matt/sergey/kristina as reviwers on operator PRs" took an action on this PR • (03/25/26)3 reviewers were added to this PR based on Anton Bykov's automation. |
| CpuPolicy: spec.CpuPolicy, | ||
| } | ||
| if spec.Dynamic != nil { | ||
| fields.ComputeExtraCores = spec.Dynamic.ComputeExtraCores |
There was a problem hiding this comment.
what if ComputeExtraCores is changed, but we are drive wekacontainer?
will it mean that hash is chnaged then and pod should be rotated?
There was a problem hiding this comment.
yes, all tracked fields will cause a rotation similar to an upgrade (for all containers, same order, one by one, but no image-specific operations)
There was a problem hiding this comment.
it seems like this hash should be calculated per role so that we do not rotate pods that won't actually get any updates
There was a problem hiding this comment.
yeah, sounds right
954e434 to
14174a7
Compare
14174a7 to
e6b40b8
Compare

TL;DR
Introduces cluster configuration hash tracking to trigger pod rotation when cluster spec changes beyond just image updates, enabling proper rolling updates for configuration changes.
What changed?
PodConfigVersionenvironment variable configuration andWekaRuntimeVersionconstant to track runtime changesclusterConfigHash()function that generates SHA-256 hash from cluster image, version numbers, and tracked spec fields (network, tolerations, hugepages, etc.)TargetClusterSpecHashfield to container specs andClusterSpecHashAnnotationto pod annotations for trackingApplyUpdatableSpecToContainer()andPropagateSpecToContainer()functionsHow to test?
TargetClusterSpecHashand pods are rotated to apply changesWhy make this change?
Previously, only image changes would trigger pod rotation during upgrades. Configuration changes to cluster specs (network settings, resource allocations, tolerations, etc.) would update container specs but not rotate pods, leaving running pods with stale configurations. This change ensures any meaningful cluster configuration change triggers proper pod rotation to apply the new settings.