fix: propagation for untracked spec fields#2404
Open
rugggger wants to merge 1 commit intographite-base/2404from
Open
fix: propagation for untracked spec fields#2404rugggger wants to merge 1 commit intographite-base/2404from
rugggger wants to merge 1 commit intographite-base/2404from
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. How to use the Graphite Merge QueueAdd the label main-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
graphite-app
bot
requested review from
assafgi,
kristina-solovyova and
tigrawap
Graphite Automations"Add anton/matt/sergey/kristina as reviwers on operator PRs" took an action on this PR • (03/26/26)3 reviewers were added to this PR based on Anton Bykov's automation. |
rugggger
force-pushed
the
03-24-fix_pods_rotation
branch
from
14174a7 to
e6b40b8
Compare
rugggger
force-pushed
the
03-26-fix_propagation_for_untracked_spec_fields
branch
from
d637221 to
1503e82
Compare
rugggger
force-pushed
the
03-26-fix_propagation_for_untracked_spec_fields
branch
from
1503e82 to
7fb8bbd
Compare
rugggger
changed the base branch from
03-24-fix_pods_rotation
to
graphite-base/2404
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Separated scheduling field propagation from pod rotation by introducing immediate field updates for tolerations, node selectors, and CPU policies.
What changed?
clusterConfigTrackedFieldsto prevent unnecessary pod rotationspropagateSchedulingFieldsfunction that immediately updates tolerations, node selectors, CPU policies, core IDs, labels, and annotations on existing containers without requiring pod restartsHow to test?
Why make this change?
This optimization reduces unnecessary downtime by avoiding pod rotations when only scheduling-related fields change. Since tolerations, node selectors, and CPU policies can be updated on running containers, there's no need to restart pods for these changes, improving cluster availability and reducing operational overhead.