fix: snap float boundary segments to integer in all_touched rasterize (fixes #3384)#3387
Closed
gaoflow wants to merge 1 commit into
Closed
fix: snap float boundary segments to integer in all_touched rasterize (fixes #3384)#3387gaoflow wants to merge 1 commit into
gaoflow wants to merge 1 commit into
Conversation
|
Hi @gaoflow, thanks for the PR! Would you mind filing a quick New contributor introduction issue when you get a chance? It helps us point you at issues that fit what you'd like to work on. Most fields are optional. Reviewing your PR doesn't depend on it, just a friendly nudge. |
Contributor
Author
|
Thanks for the heads-up. I missed #3386; this is redundant, so I’ll leave this closed. I’ll open the contributor introduction before picking up more xarray-spatial work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under
all_touched=True, the dask tile workers recomputeworld-to-pixel coordinates per tile, which can nudge on-grid boundary
segments by a few ULPs (e.g. 15.0 → 14.999999999999996). The supercover
walk then misses the correct cell row/col, diverging from the eager path.
This snaps the float pixel coordinates to the nearest integer when they
are within 8× machine epsilon (relative to coordinate magnitude), making
the dask+numpy and dask+cupy backends match the eager path pixel-for-pixel.
Fixes all merge modes (first, last, max, min, sum, count). No effect on
all_touched=Falseor off-grid polygons.