Skip to content

fix: snap float boundary segments to integer in all_touched rasterize (fixes #3384) #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaoflow wants to merge 1 commit into from
Closed

fix: snap float boundary segments to integer in all_touched rasterize (fixes #3384) #3387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions xrspatial/rasterize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,6 +1059,19 @@ def _extract_polygon_boundary_segments_float(geometries, geom_ids, bounds,
cx1 = (cx1_w - xmin) / px
cy1 = (ymax - cy1_w) / py

# Snap to nearest integer when within a tiny relative tolerance.
# The dask tile workers re-extract boundary segments per tile with
# a slightly different world-to-pixel transform, which can nudge
# on-grid coordinates (e.g. 15.0 -> 14.999999999999996). Snapping
# here makes the tile path match the eager path pixel-for-pixel
# under all_touched=True.
snap_tol = np.finfo(np.float64).eps * 8
for arr in (cx0, cy0, cx1, cy1):
scale = np.maximum(np.abs(arr), 1.0)
rounded = np.round(arr)
mask = np.abs(arr - rounded) <= scale * snap_tol
np.copyto(arr, rounded, where=mask)

v = valid
return (cx0[v], cy0[v], cx1[v], cy1[v], seg_ids[v])

Expand Down
Loading