fix: prevent cancelled reminders from being rescheduled - #2
Open
kernel-oops wants to merge 1 commit into
Open
Conversation
kernel-oops
marked this pull request as ready for review
July 20, 2026 14:58
This was referenced Jul 23, 2026
Author
|
A consolidated integration PR is now available at #5. It deliberately combines #2, #3, and #4, resolves their overlapping scheduler changes, and adds regression fixes found while stress-testing the combined lifecycle. This PR is left open for history/discussion, but the consolidated PR is the recommended merge path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The timer handle was removed before
session.prompt()completed. A concurrentreminderremovecould delete state and storage, but the still-running callback would later save and schedule the same recurring reminder again. Old plugin instances could similarly continue after a hot reload.The fix gives each project a process-global scheduler generation, each scheduled execution an ownership token and abort controller, and each reminder a serialized persistence chain. Cancellation invalidates ownership before awaiting deletion, so stale continuations cannot recreate a reminder. Replacement initialization invalidates old work synchronously and drains persistence before reading storage.
Tests
Verified in the development environment:
bun test— 54 passed, 107 assertionsbun x tsc --noEmitgit diff --check upstream/main..HEAD