fix: harden reminder lifecycle and cross-process execution#5
Open
kernel-oops wants to merge 5 commits into
Open
fix: harden reminder lifecycle and cross-process execution#5kernel-oops wants to merge 5 commits into
kernel-oops wants to merge 5 commits into
Conversation
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a consolidated, integration-tested replacement for #2, #3, and #4.
It combines the independently developed reminder reliability fixes into one coherent implementation:
Why a consolidated PR
The three original PRs overlap substantially in the scheduler and tests. Reviewing or merging them independently would require resolving their lifecycle behavior manually. This branch integrates them deliberately and adds fixes for races found only while testing the combined implementation.
The original PRs are left open for history and discussion, but this PR is intended to supersede:
Important behavior
Verification
Final committed suite:
bun test— 78 passed, 0 failed, 174 assertionsbun x tsc --noEmitgit diff --check origin/main..HEADnpm pack --dry-run --jsonAdditional stress/regression runs included:
All passed on the final branch.