Update caf to use new paffy Cigar array API#1905
Open
benedictpaten wants to merge 2 commits intomasterfrom
Open
Update caf to use new paffy Cigar array API#1905benedictpaten wants to merge 2 commits intomasterfrom
benedictpaten wants to merge 2 commits intomasterfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The paffy submodule refactored Cigar from a singly-linked list to a contiguous array container with CigarRecord entries, accessed via cigar_count() and cigar_get(). Update pinchIterator.c and pinchIteratorTest.c to use the new API. Also sync paffy's embedded sonLib to the cactus-level sonLib before building, as the new paffy code requires stFile_getLineFromFileWithBufferUnlocked which was added in the updated sonLib. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
8816b372) and refactoredCigarfrom a singly-linked list to a contiguous array container (CigarRecord[]) accessed viacigar_count()/cigar_get()caf/impl/pinchIterator.cto replaceCigar *opcursor with an integer index and rewrote traversal using the new array accessorscaf/tests/pinchIteratorTest.cto use the new array API for both traversal and constructionMakefilefix to sync paffy's embedded sonLib to the cactus-level sonLib before building, so thatstFile_getLineFromFileWithBufferUnlocked(added in the updated sonLib) is available when compiling paffyTest plan
make -j 8builds cleanly with no errors./bin/stCafTestspasses all 17 tests includingtestPinchIteratorFromFile🤖 Generated with Claude Code