Update vendored System.Reflection.Metadata#8455
Update vendored System.Reflection.Metadata#8455andrewlock wants to merge 12 commits intoandrew/remove-more-vendored-codefrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d76ae4cf88
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d76ae4c to
4820815
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8455) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8455) - mean (72ms) : 69, 75
master - mean (71ms) : 69, 73
section Bailout
This PR (8455) - mean (76ms) : 75, 78
master - mean (76ms) : 73, 79
section CallTarget+Inlining+NGEN
This PR (8455) - mean (1,060ms) : 1015, 1105
master - mean (1,062ms) : 1019, 1105
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8455) - mean (112ms) : 109, 116
master - mean (112ms) : 109, 116
section Bailout
This PR (8455) - mean (114ms) : 112, 116
master - mean (114ms) : 112, 117
section CallTarget+Inlining+NGEN
This PR (8455) - mean (765ms) : 745, 785
master - mean (784ms) : 761, 807
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8455) - mean (100ms) : 95, 104
master - mean (100ms) : 96, 103
section Bailout
This PR (8455) - mean (101ms) : 98, 104
master - mean (100ms) : 97, 102
section CallTarget+Inlining+NGEN
This PR (8455) - mean (934ms) : 908, 960
master - mean (930ms) : 890, 971
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8455) - mean (99ms) : 97, 101
master - mean (98ms) : 94, 102
section Bailout
This PR (8455) - mean (100ms) : 97, 103
master - mean (99ms) : 96, 103
section CallTarget+Inlining+NGEN
This PR (8455) - mean (819ms) : 778, 860
master - mean (819ms) : 780, 859
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8455) - mean (211ms) : 206, 215
master - mean (206ms) : 201, 211
section Bailout
This PR (8455) - mean (215ms) : 210, 219
master - mean (210ms) : 206, 213
section CallTarget+Inlining+NGEN
This PR (8455) - mean (1,222ms) : 1178, 1266
master - mean (1,207ms) : 1169, 1246
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8455) - mean (305ms) : 297, 312
master - mean (297ms) : 289, 305
section Bailout
This PR (8455) - mean (306ms) : 300, 312
master - mean (299ms) : 293, 306
section CallTarget+Inlining+NGEN
This PR (8455) - mean (997ms) : 963, 1030
master - mean (1,002ms) : 964, 1040
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8455) - mean (298ms) : 292, 305
master - mean (292ms) : 286, 297
section Bailout
This PR (8455) - mean (299ms) : 294, 304
master - mean (293ms) : 288, 297
section CallTarget+Inlining+NGEN
This PR (8455) - mean (1,182ms) : 1153, 1211
master - mean (1,167ms) : 1124, 1210
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8455) - mean (297ms) : 292, 303
master - mean (289ms) : 283, 296
section Bailout
This PR (8455) - mean (298ms) : 292, 304
master - mean (290ms) : 284, 296
section CallTarget+Inlining+NGEN
This PR (8455) - mean (1,091ms) : 980, 1201
master - mean (1,067ms) : 971, 1162
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-04-15 15:01:33 Comparing candidate commit b4b5712 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 87 known flaky benchmarks.
|
88354de to
a2f94ba
Compare
00c728d to
b4b5712
Compare
b4b5712 to
58b049c
Compare
9f055d8 to
fa2694a
Compare
Summary of changes
Reason for change
We want to update our vendored .NET library versions.
Implementation details
Test coverage
This is the test, if it compiles and tests pass, we should be ok 🤞
Other details
https://datadoghq.atlassian.net/browse/APMLP-1207
Part of a stack updating our vendored system code
Update vendored System.Collections.Immutable #8391
Use the built-in System.Reflection.Metadata types for .NET Core #8454