Introduce IFalloutCommand dispatch with DI for Fallout.Cli (#392, PR 0) by ChrisonSimtian · Pull Request #394 · Fallout-build/Fallout

ChrisonSimtian · 2026-06-17T09:43:26Z

Replaces the reflection-over-Program CLI dispatch with one-command-per-type behind a typed IFalloutCommand, resolved via Microsoft.Extensions.DependencyInjection. PR 0 of an incremental series — lands the abstraction, dispatcher, and first conversion; a transitional adapter keeps the other 13 handlers working so nothing regresses.

What changed

IFalloutCommand + CommandDispatcher replace Program.Handle; resolution stays dash/case-insensitive (every spelling the old reflection accepted).
IConsolePrompts / SpectreConsolePrompts — Spectre prompt helpers lifted off Program into an injectable service.
RunCommand — first real conversion. DelegateCommand adapts the 13 still-legacy handlers so dispatch is uniform; each follow-up PR deletes one.
Reflection dispatch removed; CommandDispatcherTests add first dispatch coverage.

Why it's not breaking

Fallout.Cli is the tool Exe, not a consumed library; the :command surface and shell-function names are preserved exactly. Hence target/2026 / main, no breaking-change label.

Verification

dotnet build src/Fallout.Cli clean · Fallout.Cli.Tests 30 pass · fallout :bogus prints the full command manifest.

Follow-ups (#392): setup · update · add-package · cake-convert/clean · complete · get-configuration · secrets · trigger · navigation → then collapse Program to a thin entry point.

Part of #392.

🤖 Generated with Claude Code

Replace the reflection-over-Program command dispatch (the partial god-class described in #392) with a typed command abstraction resolved through Microsoft.Extensions.DependencyInjection. This is the foundation PR: it lands the abstraction, the dispatcher, the prompt service, and the first real command conversion, with the remaining handlers converted one per follow-up PR. - Add public IFalloutCommand (Name + Execute) and a CommandDispatcher that resolves by name, dash- and case-insensitively, preserving every spelling the old reflection accepted (:add-package == :addpackage, :PopDirectory, ...). - Move the Spectre prompt/render helpers off Program into an injectable IConsolePrompts / SpectreConsolePrompts (namespace Fallout.Cli.Prompts to avoid colliding with System.Console). Program keeps thin static delegators so the not-yet-extracted handlers compile; the last conversion deletes them. - Convert Run into a real RunCommand type; delete Program.Run.cs. - Adapt the 13 still-legacy handlers via a transitional DelegateCommand so the registry and dispatch are uniform from day one. Each future PR deletes one registration line plus its Program.X.cs partial. - Delete the reflection dispatch and its "add assertions about return type and parameters" TODO; typed commands make signature-mismatch dispatch impossible. - Add CommandDispatcherTests (first-ever dispatch coverage): name matching, dash/case insensitivity, exit-code passthrough, unknown-command listing, empty token, and all default-routing branches. - Add .vscode launch/build tasks for debugging the global tool from source. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Bump the cross-command helpers (GetConfiguration(buildScript, evaluate), AddOrReplacePackage, WriteBuildScripts, WriteConfigurationFile, GetTemplate, PrintInfo, CurrentBuildScriptName, BUILD_PROJECT_FILE) from private to internal so the per-command IFalloutCommand types extracted in the #392 follow-up PRs can call them during the transition. These move into dedicated services in the final collapse PR; this is the minimal enabler that lets each command be converted in an independent, conflict-free PR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

This PR refactors Fallout.Cli command dispatch from reflection over Program methods to a typed IFalloutCommand model routed through a CommandDispatcher, with command instances resolved via Microsoft.Extensions.DependencyInjection. It introduces an injectable prompts abstraction and converts :run to the new command type while adapting the remaining legacy handlers via a DelegateCommand bridge.

Changes:

Introduces IFalloutCommand, CommandDispatcher, and a transitional DelegateCommand adapter; updates Program.Main to dispatch via a DI container.
Extracts console prompting/rendering into IConsolePrompts + SpectreConsolePrompts, keeping temporary Program forwarders for legacy handlers.
Adds initial unit tests for dispatch behavior and wires DI into Fallout.Cli package references (central version in Directory.Packages.props).

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tests/Fallout.Cli.Tests/CommandDispatcherTests.cs	Adds unit coverage for dispatcher matching/forwarding, default routing, and error output.
src/Fallout.Cli/Prompts/SpectreConsolePrompts.cs	New Spectre-based implementation of interactive prompts.
src/Fallout.Cli/Prompts/IConsolePrompts.cs	New abstraction for prompt/console interactions to support DI/testing.
src/Fallout.Cli/Program.Setup.cs	Promotes helper methods to `internal` for reuse during incremental command extraction.
src/Fallout.Cli/Program.GetConfiguration.cs	Promotes shared constants/helpers to `internal` for reuse during extraction.
src/Fallout.Cli/Program.cs	Replaces reflection dispatch with DI-built dispatcher and registers commands/adapters.
src/Fallout.Cli/Program.AddPackage.cs	Promotes helper to `internal` to support incremental refactor.
src/Fallout.Cli/Fallout.Cli.csproj	Adds DI package reference (centrally versioned).
src/Fallout.Cli/Commands/RunCommand.cs	Converts `:run` into a standalone `IFalloutCommand` implementation.
src/Fallout.Cli/Commands/IFalloutCommand.cs	Introduces the command contract used for typed dispatch.
src/Fallout.Cli/Commands/DelegateCommand.cs	Adds transitional adapter for legacy `Program.X` handlers.
src/Fallout.Cli/CommandDispatcher.cs	Implements dash/case-insensitive routing and default behavior (setup/run).
Directory.Packages.props	Adds central package version for `Microsoft.Extensions.DependencyInjection`.
.vscode/tasks.json	Adds VS Code build task for the CLI project.
.vscode/launch.json	Adds VS Code launch configurations for common CLI debug flows.

Comments suppressed due to low confidence (1)

src/Fallout.Cli/Commands/RunCommand.cs:17

RunCommand is declared public, but command types appear to be an internal implementation detail of the CLI tool (and the interface is intended to be internal-by-convention). Making the command type internal keeps the assembly’s public API smaller while still working with DI and tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

we currently dont plan to expose any of those, so we can make these internal. If we need to expose those inside of fallout, we can do so with `<InternalsVisibleTo/>` or at some point make a conscious decision to publish those interfaces for wider, public use Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

src/Fallout.Cli/Commands/RunCommand.cs:21

RunCommand is public even though the command abstraction is explicitly internal-by-convention; this unintentionally expands the public surface of the global tool assembly. Consider making command types internal until a versioned plugin SDK exists.

+    /// <summary>
+    /// The command name as typed after the <c>:</c> prefix (prefer dash form, e.g. <c>"add-package"</c>).\
+    /// Matched case-insensitively and with dashes ignored (so <c>:addpackage</c> also matches).\
+    /// Legacy commands may still use PascalCase names (e.g. <c>"GetNextDirectory"</c>).


+      // Prompts you for the command/args each launch, e.g. ":get-configuration" or ":bogus".
+      "name": "fallout (ask for args)",
+      "type": "coreclr",
+      "request": "launch",
+      "preLaunchTask": "build-cli",
+      "program": "${workspaceFolder}/src/Fallout.Cli/bin/Debug/net10.0/Fallout.Cli.dll",
+      "args": "${input:falloutArgs}",
+      "cwd": "${workspaceFolder}",
+      "console": "integratedTerminal",
+      "stopAtEntry": false
+    },


+      // Dispatch error path — prints the command manifest, no side effects.
+      "name": "fallout :bogus",
+      "type": "coreclr",
+      "request": "launch",
+      "preLaunchTask": "build-cli",
+      "program": "${workspaceFolder}/src/Fallout.Cli/bin/Debug/net10.0/Fallout.Cli.dll",
+      "args": [":bogus"],
+      "cwd": "${workspaceFolder}",
+      "console": "integratedTerminal"
+    },


+      // Real command via the DelegateCommand path — read-only.
+      "name": "fallout :get-configuration",
+      "type": "coreclr",
+      "request": "launch",
+      "preLaunchTask": "build-cli",
+      "program": "${workspaceFolder}/src/Fallout.Cli/bin/Debug/net10.0/Fallout.Cli.dll",
+      "args": [":get-configuration"],
+      "cwd": "${workspaceFolder}",
+      "console": "integratedTerminal"
+    }


+      "id": "falloutArgs",
+      "type": "promptString",
+      "description": "Arguments to pass to fallout (space-separated), e.g. ':get-configuration'",
+      "default": ":bogus"
+    }


ChrisonSimtian · 2026-06-30T00:35:46Z

@dennisdoomen would appreciate your set of eyes here, this is going to unlock a whole lot of refactoring around the cli.
Once this has landed I'll use the same approach to go over all the other static god-classes around here ...

ChrisonSimtian · 2026-06-30T09:07:20Z

Superseded by #448 — re-raised from the fork branch (ChrisonSimtian:cli-command-dispatch-foundation) so the branch no longer lives on this repo. Same history and diff. Branch left in place for now to avoid auto-closing the replacement; it'll be cleaned up once #448 merges.

ChrisonSimtian requested a review from a team as a code owner June 17, 2026 09:43

ChrisonSimtian added the target/2026 Targets the 2026 calendar-version line (current). See ADR-0004. label Jun 17, 2026

ChrisonSimtian requested a review from Copilot June 22, 2026 08:18

Copilot started reviewing on behalf of ChrisonSimtian June 22, 2026 08:18 View session

Copilot AI reviewed Jun 22, 2026

View reviewed changes

Comment thread src/Fallout.Cli/Commands/IFalloutCommand.cs Outdated

Comment thread src/Fallout.Cli/Commands/IFalloutCommand.cs Outdated

Comment thread src/Fallout.Cli/Prompts/IConsolePrompts.cs Outdated

Comment thread src/Fallout.Cli/Prompts/SpectreConsolePrompts.cs Outdated

ChrisonSimtian mentioned this pull request Jun 26, 2026

Add NuGet package analyzer (redundant & conflicting references) with :analyze packages CLI #423

Open

ChrisonSimtian requested a review from Copilot June 28, 2026 23:08

Copilot started reviewing on behalf of ChrisonSimtian June 28, 2026 23:08 View session

Copilot AI reviewed Jun 28, 2026

View reviewed changes

ChrisonSimtian requested a review from dennisdoomen June 30, 2026 00:34

This was referenced Jun 30, 2026

Introduce IFalloutCommand dispatch with DI for Fallout.Cli (#392, PR 0) ChrisonSimtian/Fallout#16

Open

Introduce IFalloutCommand dispatch with DI for Fallout.Cli (#392, PR 0) #448

Merged

ChrisonSimtian closed this Jun 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Introduce IFalloutCommand dispatch with DI for Fallout.Cli (#392, PR 0)#394

Introduce IFalloutCommand dispatch with DI for Fallout.Cli (#392, PR 0)#394
ChrisonSimtian wants to merge 3 commits into
mainfrom
cli-command-dispatch-foundation

ChrisonSimtian commented Jun 17, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

ChrisonSimtian commented Jun 30, 2026

Uh oh!

ChrisonSimtian commented Jun 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

ChrisonSimtian commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Why it's not breaking

Verification

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

ChrisonSimtian commented Jun 30, 2026

Uh oh!

ChrisonSimtian commented Jun 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ChrisonSimtian commented Jun 17, 2026 •

edited

Loading