Skip to content

test(sanitizer-accessibility): verify Accessibility Standards & Screen Reader Aria Compliance#4875

Open
jeevitha-14s wants to merge 2 commits into
JhaSourav07:mainfrom
jeevitha-14s:feature/sanitizer-accessibility-v2
Open

test(sanitizer-accessibility): verify Accessibility Standards & Screen Reader Aria Compliance#4875
jeevitha-14s wants to merge 2 commits into
JhaSourav07:mainfrom
jeevitha-14s:feature/sanitizer-accessibility-v2

Conversation

@jeevitha-14s
Copy link
Copy Markdown
Contributor

Description

Creates lib/svg/sanitizer.accessibility.test.ts targeting Accessibility Standards & Screen Reader Aria Compliance as required by issue #4640.
Tests pass SVG accessibility attribute values (role, aria-labelledby, aria-describedby, title, desc) through the sanitizer functions and verify the output preserves those attributes correctly.

CI note: The 15 pre-existing test failures and 97 lint warnings exist on main and are unrelated to this PR. This file passes independently — verified with npx vitest run lib/svg/sanitizer.accessibility.test.ts.

Description

Fixes #4640

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🔧 Other (Bug fix, refactoring, docs)

Visual Preview

No visual changes — this PR adds a test file only.

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have starred the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Jun 7, 2026

@jeevitha-14s is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 7, 2026

🚨 Hey @jeevitha-14s, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@jeevitha-14s jeevitha-14s force-pushed the feature/sanitizer-accessibility-v2 branch from a7193ce to bb67d3d Compare June 7, 2026 19:34
@jeevitha-14s
Copy link
Copy Markdown
Contributor Author

The 2 failing test files (ActivityLandscape.test.tsx, app/page.test.tsx)
are pre-existing failures on main unrelated to this PR. Production Build
passed. My file lib/svg/sanitizer.accessibility.test.ts has no failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:blocked This PR is blocked due to a failing CI check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(sanitizer-accessibility): verify Accessibility Standards & Screen Reader Aria Compliance (Variation 4)

1 participant