Skip to content

chore(smart-transactions-controller): reset CHANGELOG after migration#9131

Merged
cryptodev-2s merged 1 commit into
mainfrom
chore/smart-transactions-controller-reset-changelog
Jun 15, 2026
Merged

chore(smart-transactions-controller): reset CHANGELOG after migration#9131
cryptodev-2s merged 1 commit into
mainfrom
chore/smart-transactions-controller-reset-changelog

Conversation

@cryptodev-2s

Copy link
Copy Markdown
Contributor

Explanation

Phase B PR #7 of the package migration process guide for `@metamask/smart-transactions-controller`.

Replaces the imported `CHANGELOG.md` with a fresh skeleton plus a single `[Unreleased]` entry that links back to the historical changelog at the `v24.2.1` tag in the original repo. Subsequent CHANGELOG entries (from PRs in this monorepo) will accumulate under `[Unreleased]` until the first post-migration release.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Replaces the imported CHANGELOG history with a fresh skeleton and a
single [Unreleased] entry that links back to the historical
changelog in the original repo at the v24.2.1 tag.

Per Phase B PR #7 of the package-migration-process-guide.
@cryptodev-2s cryptodev-2s self-assigned this Jun 15, 2026
@cryptodev-2s cryptodev-2s requested a review from a team June 15, 2026 20:32
@cryptodev-2s cryptodev-2s added this pull request to the merge queue Jun 15, 2026
Merged via the queue into main with commit e31a6b6 Jun 15, 2026
379 checks passed
@cryptodev-2s cryptodev-2s deleted the chore/smart-transactions-controller-reset-changelog branch June 15, 2026 20:40
github-merge-queue Bot pushed a commit that referenced this pull request Jun 15, 2026
…9132)

## Explanation

Phase B PR #8 of the [package migration process
guide](https://github.com/MetaMask/core/blob/main/docs/processes/package-migration-process-guide.md)
for
[\`@metamask/smart-transactions-controller\`](https://github.com/MetaMask/core/tree/main/merged-packages/smart-transactions-controller).

Removes files that are either handled at the monorepo root or no longer
needed once the package lives in core:

| Removed | Reason |
|---|---|
| \`.github/\` | Workflows, CODEOWNERS, dependabot, PR template handled
by core's root \`.github/\` |
| \`.gitattributes\`, \`.gitignore\` | Root-level |
| \`.editorconfig\`, \`.nvmrc\` | Root-level |
| \`.prettierrc.js\`, \`eslint.config.mjs\` | Replaced by the monorepo
root configs (next PR wires the package up to them) |
| \`.yarn/\`, \`.yarnrc.yml\`, \`yarn.lock\` | Monorepo uses Yarn 4 with
a single root lockfile |
| \`scripts/\` | Source-repo release/preview scripts no longer needed |

**Kept** (matches the guide's "Keep" list): \`src/\`, \`tests/\`,
\`CHANGELOG.md\`, \`LICENSE\`, \`package.json\`, \`README.md\`,
\`jest.config.js\`, \`tsconfig*.json\`, \`typedoc.json\`,
\`setupJest.js\` (the last one will be decided in PR #9 when configs are
replaced).

No code or runtime behaviour changes.

## References

- Prior steps: history merge (#9130), CHANGELOG reset (#9131)
- Migration process:
[\`docs/processes/package-migration-process-guide.md\`](https://github.com/MetaMask/core/blob/main/docs/processes/package-migration-process-guide.md)

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them
pull Bot pushed a commit to dmrazzy/core that referenced this pull request Jun 15, 2026
…epo roots (MetaMask#9134)

## Explanation

Phase B PR #9 of the [package migration process
guide](https://github.com/MetaMask/core/blob/main/docs/processes/package-migration-process-guide.md)
for
[\`@metamask/smart-transactions-controller\`](https://github.com/MetaMask/core/tree/main/merged-packages/smart-transactions-controller).

### Replaced

- **\`tsconfig.json\`** — now extends \`../../tsconfig.packages.json\`.
Lists references for the in-monorepo upstream \`@metamask/*\` deps and
optional peers. \`noErrorTruncation\` and \`resolveJsonModule\`
preserved from the source repo's tsconfig.
- **\`tsconfig.build.json\`** — extends
\`../../tsconfig.packages.build.json\` and mirrors the same references
with \`tsconfig.build.json\` paths.
- **\`jest.config.js\`** — merges into the root
\`jest.config.packages.js\`. Preserves the package's coverage thresholds
(branches 74.65, functions 88.18, lines 92.33, statements 91.89),
\`setupJest.js\` setup, and \`testTimeout: 2500\`.

### Unchanged

- **\`typedoc.json\`** — already matches the template
(\`scripts/create-package/package-template/typedoc.json\`).
- **\`setupJest.js\`** — kept as-is; may be removable in PR #10 since
Node 18+ has native \`fetch\` and \`isomorphic-fetch\` is no longer
strictly required.

### DevDependency added

- \`deepmerge@^4.2.2\` (used by the new \`jest.config.js\`)

Package is still in \`merged-packages/\` so \`yarn install\` doesn't
include it; configs aren't exercised until Phase C PR #12 moves it into
\`packages/\`.

## References

- Prior steps: history merge (MetaMask#9130), CHANGELOG reset (MetaMask#9131), strip
source-repo-only files (MetaMask#9132)
- Migration process:
[\`docs/processes/package-migration-process-guide.md\`](https://github.com/MetaMask/core/blob/main/docs/processes/package-migration-process-guide.md)

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them
pull Bot pushed a commit to Reality2byte/core that referenced this pull request Jun 16, 2026
…th monorepo (MetaMask#9136)

## Explanation

Phase B PR #10 of the [package migration process
guide](https://github.com/MetaMask/core/blob/main/docs/processes/package-migration-process-guide.md)
for
[\`@metamask/smart-transactions-controller\`](https://github.com/MetaMask/core/tree/main/merged-packages/smart-transactions-controller).

Slims \`package.json\` down to match other non-root packages (modelled
on \`packages/transaction-controller/package.json\`).

### Scripts

- **Build** swapped to the monorepo standard \`ts-bridge ... --verbose
--clean --no-references\`; added \`build:all\`, \`build:docs\`.
- Added monorepo-standard \`changelog:update\`, \`changelog:validate\`,
\`since-latest-release\`, \`test:clean\`, \`test:verbose\`,
\`test:watch\`.
- \`messenger-action-types:check\`/\`:generate\` now invoke the
workspace messenger-cli via \`tsx
../../packages/messenger-cli/src/cli.ts\` instead of the package-local
binary.
- \`test\` reduced to \`jest --reporters=jest-silent-reporter\` (drops
\`attw --pack\`; the dep that backed it is also removed below).
- Removed all \`lint*\` scripts and \`prepack\` — lint runs at the
monorepo root, prepack is root-handled.

### DevDeps

| Removed (provided by root) | Kept (per-package toolchain) |
|---|---|
| \`@arethetypeswrong/cli\` (no longer used) |
\`@metamask/auto-changelog\` |
| \`@lavamoat/allow-scripts\` | \`@metamask/gas-fee-controller\` (test
helper) |
| \`@lavamoat/preinstall-always-fail\` | \`@metamask/json-rpc-engine\`
(test helper) |
| \`@metamask/eslint-config*\` | \`@ts-bridge/cli\` |
| \`@metamask/messenger-cli\` (now invoked via \`tsx + path\`) |
\`deepmerge\` |
| \`eslint\`, \`eslint-*\` | \`jest\` |
| \`isomorphic-fetch\` | \`nock\` |
| \`prettier\`, \`prettier-plugin-packagejson\` | \`ts-jest\` |
| \`typescript-eslint\` | \`typescript\` (kept per guide exception) |
| | \`tsx\`, \`typedoc\`, \`typedoc-plugin-missing-exports\` (added) |

### Other

- \`repository.url\` updated to point at \`MetaMask/core\`.
- Added required workspace fields: \`keywords\`, \`homepage\`, \`bugs\`.
Description now ends with a period.
- Removed the dangling \`peerDependenciesMeta\` block (it had no
matching \`peerDependencies\` entries).
- Removed per-package \`lavamoat\` config and \`packageManager\` — both
handled at the monorepo root.

### Known holdout

\`nock\` is intentionally kept at \`^14.0.0-beta.7\` rather than
aligning to root's \`^13.3.1\` — downgrade breaks 22 tests. Will be
resolved in Phase C PR #12 via either an
\`ALLOWED_INCONSISTENT_DEPENDENCIES\` entry or a core-side nock bump.

Package is still in \`merged-packages/\` so \`yarn install\` doesn't
actually exercise this manifest yet; it's verified in PR #12 when the
package moves into \`packages/\`.

## References

- Prior steps: history merge (MetaMask#9130), CHANGELOG reset (MetaMask#9131), strip
files (MetaMask#9132), replace configs (MetaMask#9134)
- Migration process:
[\`docs/processes/package-migration-process-guide.md\`](https://github.com/MetaMask/core/blob/main/docs/processes/package-migration-process-guide.md)

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants