Skip to content

MDv6 Ansible Flashing#3614

Draft
Andrewyx wants to merge 51 commits intoUBC-Thunderbots:masterfrom
Andrewyx:Andrewyx/MDv6_Flashing
Draft

MDv6 Ansible Flashing#3614
Andrewyx wants to merge 51 commits intoUBC-Thunderbots:masterfrom
Andrewyx:Andrewyx/MDv6_Flashing

Conversation

@Andrewyx
Copy link
Contributor

Description

This PR integrates the work in #3550 and introduces ansible to complete the remote deployment process of the motor driver board firmware.

Testing Done

Resolved Issues

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

Comment on lines +65 to +67
# Use the Low-Layer APIs because it gives us more control over the hardware (as opposed to the HAL).
# https://www.st.com/content/ccc/resource/technical/document/user_manual/56/32/53/cb/69/86/49/0e/DM00223149.pdf/files/DM00223149.pdf/jcr:content/translations/en.DM00223149.pdf
"USE_FULL_LL_DRIVER",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This define is probably not necessary since we are using the HAL, not LL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants