CI: Remove node version from test matrix, use node version from .nvmrc#407
Merged
CI: Remove node version from test matrix, use node version from .nvmrc#407
.nvmrc#407Conversation
ockham
changed the title
.nvmrc
ockham
changed the title
.nvmrc.nvmrc
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It occurred to me that it doesn't make much sense to run E2E tests against different node versions. SCF if a WP plugin; while it uses node to build JS assets, it's not used at all to run the code; that happens solely in the user's browser.
Consequently, it should be enough to run E2E tests only against one node version. (The edge case of E2E tests themselves using language constructs that are available in one node version but not in another isn't compelling enough to warrant running them against different node versions.)
I've updated the workflow to use the node version set in
.nvmrc(currently22).Use of AI Tools
None