Skip to content

CI: Remove node version from test matrix, use node version from .nvmrc #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ockham merged 2 commits into from
Apr 14, 2026
+11 −10
Merged

CI: Remove node version from test matrix, use node version from .nvmrc #407

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47a3012
CI: Remove node 24 from e2e test matrix
ockham Apr 14, 2026
e42e555
CI: Use node version from .nvmrc
ockham Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ permissions: {}

jobs:
test:
name: E2E - Node ${{ matrix.node }} / WP ${{ matrix.wp }} / Shard ${{ matrix.shard }}/4
name: E2E - WP ${{ matrix.wp }} / Shard ${{ matrix.shard }}/4
runs-on: ubuntu-latest
permissions:
contents: read
Expand All @@ -28,13 +28,9 @@ jobs:
matrix:
event: ['${{ github.event_name }}']
shard: [1, 2, 3, 4]
node: ['22', '24']
wp: ['6.2', '6.8', 'latest', 'trunk']
exclude:
# On PRs: only test Node 22 + WP latest and trunk for fast feedback
# On trunk: full matrix with node 24 and minimum WP version
- event: 'pull_request'
node: '24'
# On PRs: Skip minimum supported WP version for faster feedback
- event: 'pull_request'
wp: '6.2'

Expand All @@ -47,9 +43,14 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: ${{ matrix.node }}
node-version-file: '.nvmrc'
cache: 'npm'

- name: Get Node.js version
id: node-version
run: |
echo "NODE_VERSION=$(node -v)" >> "$GITHUB_OUTPUT"

- name: Install dependencies
run: |
npm ci
Expand Down Expand Up @@ -77,15 +78,15 @@ jobs:
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
if: ${{ !cancelled() }}
with:
name: failures-artifacts--node${{ matrix.node }}-wp${{ matrix.wp }}-shard${{ matrix.shard }}
name: failures-artifacts--node${{ steps.node-version.outputs.NODE_VERSION }}-wp${{ matrix.wp }}-shard${{ matrix.shard }}
path: artifacts/test-results
if-no-files-found: ignore

- name: Archive blob reports (HTML)
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
if: ${{ !cancelled() }}
with:
name: blob-reports--node${{ matrix.node }}-wp${{ matrix.wp }}-shard${{ matrix.shard }}
name: blob-reports--node${{ steps.node-version.outputs.NODE_VERSION }}-wp${{ matrix.wp }}-shard${{ matrix.shard }}
path: blob-report
if-no-files-found: ignore

Expand Down Expand Up @@ -143,7 +144,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: '22'
node-version-file: '.nvmrc'
cache: 'npm'

- name: Install dependencies
Expand Down
Loading