Skip to content

Set upper bounds for setuptools and wheel-filename #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mghantous merged 2 commits into from
Feb 10, 2026
Merged

Set upper bounds for setuptools and wheel-filename #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38e52d6
Set upper bounds for setuptools and wheel-filename
mghantous Feb 10, 2026
842f063
fix tests
mghantous Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
# requirements.txt omits setuptools (pip-compile); setuptools<82 needed for pkg_resources (devpi-server)
python -m pip install 'setuptools<82'
python -m pip install -r requirements.txt
python -m pip install --no-deps -e .
if [ "${{ matrix.python-version }}" != "3.13" ]; then # workaround for TheKevJames/coveralls-python#523
Expand Down
4 changes: 2 additions & 2 deletions core-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
devpi-plumber>=0.2.14
setuptools
setuptools<82 # setuptools 82 drops pkg_resources
Copy link

@gemini-code-assist gemini-code-assist bot Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Pinning setuptools is a good immediate fix to prevent breakage from pkg_resources being removed. However, pkg_resources is deprecated. For a more robust long-term solution, you should consider migrating the code in devpi_builder/requirements.py to use modern alternatives like the packaging library (which is already a dependency) for name and version handling. This would remove the runtime dependency on setuptools and make the project more future-proof.

wheel
wheel-filename
wheel-filename<2 # wheel-filename 2 breaks imports of InvalidFilenameError, parse_wheel_filename
Copy link

@gemini-code-assist gemini-code-assist bot Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Pinning wheel-filename is a good way to prevent breakage from the API changes in version 2. As a follow-up, it would be beneficial to create an issue to track updating the code in devpi_builder/wheeler.py to use the new API of wheel-filename>=2. This will ensure the project stays current with its dependencies and can benefit from future improvements.

wheel-inspect>=1.6.0
pip>=1.5.3
junit-xml>=1.9 # First version to support to_xml_report_file
Expand Down