assigning user tags#369
Open
cboldtsus wants to merge 7 commits into
Open
Conversation
I created a basis for how the tags will be created and where they will be stored, but I did not get as far as I would've liked
csmith1188
requested changes
Oct 23, 2022
Comment on lines
+255
to
+258
| if tags = True | ||
| else: | ||
| sD.studentDict[remote]['perms'] = int(user[3]) | ||
| sD.studentDict[remote]['tags'] = json.loads(user[13]) |
Owner
There was a problem hiding this comment.
How does this not cause a huge error?
Collaborator
Author
There was a problem hiding this comment.
Ive been trying to fix this, it only breaks when making a new user, but i have no idea where else to put this, it needs this to load the tags for users. if i remove this, the tags stop working
Comment on lines
+664
to
+671
| } else if (text.startsWith("!#sound")) { | ||
| // text.splice(0, 2); | ||
| // args = text.split(" "); | ||
| // args.shift(); | ||
| chatSocket.emit("sound", packMSG(receiver, username, { command: 'bgm', file: 'rickroll.mp3'}));} | ||
| else { | ||
| chatSocket.emit("message", packMSG(receiver, username, text)); | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
This needs to be in a different PR/branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.