-
Notifications
You must be signed in to change notification settings - Fork 53
assigning user tags #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cboldtsus
wants to merge
7
commits into
csmith1188:RC
Choose a base branch
from
cboldtsus:cboldt
base: RC
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
assigning user tags #369
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ba195f8
API/Websockets UNFINISHED
Xavier2023390 74e85cf
started with #268
Xavier2023390 fcec8a8
Merge branch 'RC' into xavierBranch
Xavier2023390 0d905ed
Merge remote-tracking branch 'upstream/RC' into xavierBranch
Xavier2023390 66256ae
Testing Tags
Xavier2023390 c03122c
Tags are "Working"
Xavier2023390 893e182
Halfway on issue #349
cboldtsus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [1017/105201.979:ERROR:registration_protocol_win.cc(106)] CreateFile: The system cannot find the file specified. (0x2) | ||
| [1017/111806.752:ERROR:registration_protocol_win.cc(106)] CreateFile: The system cannot find the file specified. (0x2) | ||
| [1017/111809.960:ERROR:registration_protocol_win.cc(106)] CreateFile: The system cannot find the file specified. (0x2) | ||
|
cboldtsus marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import json | ||
|
|
||
| tag = ["grade", "team"] | ||
| print(json.dumps(tag)) | ||
|
cboldtsus marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -661,9 +661,14 @@ <h2 id="ulHeading">Online</h2> | |
| // args = text.split(" "); | ||
| // args.shift(); | ||
| chatSocket.emit("help", packMSG(receiver, username, text)); | ||
| } else { | ||
| } else if (text.startsWith("!#sound")) { | ||
| // text.splice(0, 2); | ||
| // args = text.split(" "); | ||
| // args.shift(); | ||
| chatSocket.emit("sound", packMSG(receiver, username, { command: 'bgm', file: 'rickroll.mp3'}));} | ||
| else { | ||
| chatSocket.emit("message", packMSG(receiver, username, text)); | ||
| } | ||
| } | ||
|
Comment on lines
+664
to
+671
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needs to be in a different PR/branch. |
||
| boxes.inputBox.value = ""; | ||
| boxes.inputBox.focus(); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this not cause a huge error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ive been trying to fix this, it only breaks when making a new user, but i have no idea where else to put this, it needs this to load the tags for users. if i remove this, the tags stop working