Skip to content

fix(replay): Ensure maskAttributes works with maskAllText=false#20491

Open
mydea wants to merge 1 commit intodevelopfrom
fn/replay-fix-masking
Open

fix(replay): Ensure maskAttributes works with maskAllText=false#20491
mydea wants to merge 1 commit intodevelopfrom
fn/replay-fix-masking

Conversation

@mydea
Copy link
Copy Markdown
Member

@mydea mydea commented Apr 24, 2026

This was found by claude security review, we did not look at maskAttributes properly when maskAllText=false was configured.

@mydea mydea requested review from billyvg, chargome and logaretm April 24, 2026 09:13
@mydea mydea self-assigned this Apr 24, 2026
@mydea mydea requested a review from a team as a code owner April 24, 2026 09:13
@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 25.96 kB - -
@sentry/browser - with treeshaking flags 24.44 kB - -
@sentry/browser (incl. Tracing) 43.89 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 45.53 kB - -
@sentry/browser (incl. Tracing, Profiling) 48.84 kB - -
@sentry/browser (incl. Tracing, Replay) 83.09 kB +0.01% +6 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 72.6 kB +0.01% +7 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 87.77 kB +0.01% +6 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 100.04 kB +0.01% +8 B 🔺
@sentry/browser (incl. Feedback) 42.78 kB - -
@sentry/browser (incl. sendFeedback) 30.64 kB - -
@sentry/browser (incl. FeedbackAsync) 35.64 kB - -
@sentry/browser (incl. Metrics) 27.25 kB - -
@sentry/browser (incl. Logs) 27.38 kB - -
@sentry/browser (incl. Metrics & Logs) 28.07 kB - -
@sentry/react 27.72 kB - -
@sentry/react (incl. Tracing) 46.13 kB - -
@sentry/vue 30.81 kB - -
@sentry/vue (incl. Tracing) 45.71 kB - -
@sentry/svelte 25.98 kB - -
CDN Bundle 28.66 kB - -
CDN Bundle (incl. Tracing) 46.12 kB - -
CDN Bundle (incl. Logs, Metrics) 30.03 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 47.17 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 69 kB +0.01% +5 B 🔺
CDN Bundle (incl. Tracing, Replay) 83.19 kB +0.01% +2 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 84.22 kB +0.01% +3 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 88.68 kB +0.01% +8 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 89.76 kB +0.01% +6 B 🔺
CDN Bundle - uncompressed 83.91 kB - -
CDN Bundle (incl. Tracing) - uncompressed 137.82 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 88.06 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 141.23 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 211.66 kB +0.02% +23 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 255.28 kB +0.01% +23 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 258.68 kB +0.01% +23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 268.2 kB +0.01% +23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 271.58 kB +0.01% +23 B 🔺
@sentry/nextjs (client) 48.66 kB - -
@sentry/sveltekit (client) 44.33 kB - -
@sentry/node-core 58.37 kB +0.02% +8 B 🔺
@sentry/node 175.69 kB +0.01% +14 B 🔺
@sentry/node - without tracing 98.32 kB +0.02% +14 B 🔺
@sentry/aws-serverless 115.35 kB +0.01% +10 B 🔺

View base workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant