GUI mp4 download (encode on demand)#30
Closed
irobinson010 wants to merge 1 commit into
Closed
Conversation
New POST /api/render/mp4 re-runs the video conversion and streams back an h264 mp4 with the source's audio muxed in - called only when the user clicks the new .mp4 download button, so the preview loop stays fast. The upload/convert core is shared with /api/render via _video_from_upload (which keeps the temp source alive for audio muxing). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Video tab gains a .mp4 download that includes the source's audio. It's encode-on-demand: a new
POST /api/render/mp4re-runs the conversion and streams the file only when clicked, so the render/preview loop keeps its GIF-only speed. Upload handling is shared with/api/rendervia a refactored_video_from_uploadthat keeps the temp source file alive for the audio mux.Stacked on #29.
Test plan
video/mp4with anftypcontainer header from a GIF-clip upload; missing-file 400🤖 Generated with Claude Code