Skip to content

Fixes frame transform duplicate log#4715

Open
klakhi wants to merge 3 commits intoisaac-sim:developfrom
klakhi:klakhi/fix_frame_transform_duplicate_log
Open

Fixes frame transform duplicate log#4715
klakhi wants to merge 3 commits intoisaac-sim:developfrom
klakhi:klakhi/fix_frame_transform_duplicate_log

Conversation

@klakhi
Copy link
Contributor

@klakhi klakhi commented Feb 25, 2026

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

…rted(non_identity_offset_frames) so the message shows unique frame names only.
…rted(non_identity_offset_frames) so the message shows unique frame names only.
@github-actions github-actions bot added bug Something isn't working isaac-lab Related to Isaac Lab team labels Feb 25, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 25, 2026

Greptile Summary

Changed non_identity_offset_frames from a list to a set to prevent duplicate frame names from appearing in log messages when multiple environments reference the same frames. The log output is now sorted for consistency.

  • Replaced list with set() initialization on line 167
  • Changed append() to add() on line 228
  • Added sorted() call when logging the frame names on line 240

This fix ensures that each unique frame name appears only once in the log message, regardless of how many environments use that frame.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • Simple data structure change (list to set) with no behavioral impact beyond deduplicating log messages; the change is well-scoped and correct
  • No files require special attention

Important Files Changed

Filename Overview
source/isaaclab_physx/isaaclab_physx/sensors/frame_transformer/frame_transformer.py Changed non_identity_offset_frames from list to set to avoid duplicate frame names in logs, sorted output for consistent logging

Last reviewed commit: 4f41d84

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Collaborator

@AntoineRichard AntoineRichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@klakhi
Copy link
Contributor Author

klakhi commented Feb 25, 2026

@kellyguo11 please help merge , thanks.

@kellyguo11 kellyguo11 changed the title Klakhi/fix frame transform duplicate log Fixes frame transform duplicate log Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants