Fixes redundant string to callable#4765
Merged
ooctipus merged 10 commits intoisaac-sim:developfrom Feb 28, 2026
Merged
Conversation
d69497d to
437bbe3
Compare
Contributor
Greptile SummaryThis PR cleans up redundant string-to-callable conversion logic in the config system. With the introduction of
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 437bbe3 |
AntoineRichard
approved these changes
Feb 27, 2026
Collaborator
AntoineRichard
left a comment
There was a problem hiding this comment.
We need that in ASAP :)
801726c to
ac529bc
Compare
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With resolvable string, the string to callable is now redundant, and many assumption built with string_to_callable at update class from cfg doesn't make sense anymore (Magically change string to type during update was an logic bug).
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there