Add more utility functions for setting collection level parameters#391
Open
Add more utility functions for setting collection level parameters#391
Conversation
da8300a to
d2da1b4
Compare
2bc6560 to
4275e31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
k4FWCore::putCollectionParameterandk4FWCore::getCollectionParameterto facilitate setting and getting collection level parameters / metadatak4FWCore::putCellIDEncodingandk4FWCore::getCellIDEncodingto facilitate setting and getting CellID encoding stringsMetaDataHandlesENDRELEASENOTES
These simply wrap
(get|put)Parameter, but callpodio::collMetadataParamName(withedm4hep::labels::CellIDEncoding) under the hood first before passing things on. This is a follow up on this discussion.@jmcarcell it looks like currently the only test for CellID encoding goes through a non-functional algorithm. I think we should add one for functional algorithms as well. Do you have a preference on whether
ExampleFunctionalProducerMultiple)?