Conversation
afrind
requested review from
Oxyd,
TimEvens,
akash-a-n,
gmarzot,
michalhosna,
mondain,
peterchave and
suhasHere
as code owners
CrossExecFilter (TrackConsumer), CrossExecSubgroupFilter (SubgroupConsumer), and FetchCrossExecFilter (FetchConsumer) each forward all calls to a target executor via fire-and-forget lambdas. Requires a FIFO executor so delivery order is preserved without locks. beginSubgroup() returns a CrossExecSubgroupFilter immediately; the inner beginSubgroup runs on the target executor, and FIFO ordering guarantees it completes before any subsequent object/endOf* lambdas execute. deepCopyPayload (default true for subgroup/track, false for fetch) calls cloneCoalesced()+unshare() before crossing executor boundaries to prevent contention on the underlying buffer's atomic refcount. SubgroupConsumerUtil.h adds ObjectPayloadByteTracker, a helper that tracks multi-part object byte delivery so objectPayload() can return the correct ObjectPublishStatus. Full unit test suite (CrossExecFilterTest.cpp) using folly::ManualExecutor. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced May 25, 2026
gmarzot
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CrossExecFilter (TrackConsumer), CrossExecSubgroupFilter (SubgroupConsumer),
and FetchCrossExecFilter (FetchConsumer) each forward all calls to a target
executor via fire-and-forget lambdas. Requires a FIFO executor so delivery
order is preserved without locks.
beginSubgroup() returns a CrossExecSubgroupFilter immediately; the inner
beginSubgroup runs on the target executor, and FIFO ordering guarantees it
completes before any subsequent object/endOf* lambdas execute.
deepCopyPayload (default true for subgroup/track, false for fetch) calls
cloneCoalesced()+unshare() before crossing executor boundaries to prevent
contention on the underlying buffer's atomic refcount.
SubgroupConsumerUtil.h adds ObjectPayloadByteTracker, a helper that tracks
multi-part object byte delivery so objectPayload() can return the correct
ObjectPublishStatus.
Full unit test suite (CrossExecFilterTest.cpp) using folly::ManualExecutor.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
This change is