Conversation
afrind
requested review from
Oxyd,
TimEvens,
akash-a-n,
gmarzot,
michalhosna,
mondain,
peterchave and
suhasHere
as code owners
This was referenced May 25, 2026
gmarzot
approved these changes
May 25, 2026
Contributor
gmarzot
left a comment
gmarzot
left a comment
There was a problem hiding this comment.
@gmarzot reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on akash-a-n, michalhosna, mondain, Oxyd, peterchave, suhasHere, and TimEvens).
afrind
force-pushed
the
pr329
branch
3 times, most recently
from
c80d25c to
036df59
Compare
Dispatches MoQForwarder::Callback (onEmpty, forwardChanged, newGroupRequested) to a target executor fire-and-forget. Locks the weak_ptr on the calling thread — where the forwarder is guaranteed alive — and moves the resulting shared_ptr into the lambda to keep it alive across the executor hop without forming a permanent ownership cycle (forwarder → callback → forwarder). The weak_ptr member avoids that permanent cycle; eager locking at call-site ensures the lambda always has a valid pointer to deliver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dispatches MoQForwarder::Callback (onEmpty, forwardChanged,
newGroupRequested) to a target executor fire-and-forget. Locks the
weak_ptr on the calling thread — where the forwarder is guaranteed
alive — and moves the resulting shared_ptr into the lambda to keep it
alive across the executor hop without forming a permanent ownership
cycle (forwarder → callback → forwarder).
The weak_ptr member avoids that permanent cycle; eager locking at
call-site ensures the lambda always has a valid pointer to deliver.
This change is