Skip to content

relay: use this capture instead of shared_from_this in CrossExecFilter lambdas#328

Merged
afrind merged 1 commit into
mainfrom
pr328
May 25, 2026
Merged

relay: use this capture instead of shared_from_this in CrossExecFilter lambdas#328
afrind merged 1 commit into
mainfrom
pr328

Conversation

@afrind
Copy link
Copy Markdown
Contributor

@afrind afrind commented May 25, 2026

Avoids an atomic refcount increment/decrement on every object forwarded
through the cross-exec filter.

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com


This change is Reviewable

@gmarzot
Copy link
Copy Markdown
Contributor

gmarzot commented May 25, 2026

ha it looks like claude clobbered the reviewable link? not really able to review other than i read it and the comments.

Base automatically changed from pr327 to main May 25, 2026 16:41
…r lambdas

Avoids an atomic refcount increment/decrement on every object forwarded
through the cross-exec filter.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor Author

@afrind afrind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try again: https://reviewable.io/reviews/openmoq/moqx/328

@afrind made 1 comment.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on akash-a-n, michalhosna, mondain, Oxyd, peterchave, suhasHere, and TimEvens).

@afrind afrind merged commit a59916a into main May 25, 2026
15 of 20 checks passed
@afrind afrind deleted the pr328 branch May 25, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants