Remove direct pkg/model dependency and consolidate CI#20
Open
JeroenSoeters wants to merge 2 commits into
Open
Conversation
Remove dead code that was the only direct consumer of pkg/model: - Remove deprecated FromTarget from config.go - Delete unused pkg/descriptors package (loader, gen, pkl) - Add proper LabelConfig with DisplayName/Name queries pkg/model is now an indirect dependency.
Merge build/lint/pkl-validate/verify-schema into single checks job. Add test-integration job to CI and nightly workflows. Add notify-fixed job to nightly. Add -timeout 30m to Makefile.
browdues
approved these changes
Feb 27, 2026
browdues
left a comment
browdues
left a comment
Contributor
There was a problem hiding this comment.
One easy fix - can we return workflow dispatch
This was referenced Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/model:FromTargetfromconfig.gopkg/descriptorspackage (loader, generated Go types, PKL files — ~700 lines)LabelConfigwith$.DisplayNameas default query and$.Nameoverrides for Identity, ContainerEngine::Cluster/NodePool, and ObjectStorage resourcespkg/modelis now an indirect dependencychecksjobtest-integrationjob to CI and nightly workflows (OCI credentials still TODO)notify-fixedjob to nightly-timeout 30mto Makefiletest-integrationtarget