Skip to content

[SLOP(claude-opus-4-8-medium)] fix(rivetkit-wasm): add missing inspector_tabs field to ActorConfigInput conversion#5245

Open
NathanFlurry wants to merge 1 commit into
mainfrom
stack/slop-claude-opus-4-8-medium-fix-rivetkit-wasm-add-missing-inspector_tabs-field-to-actorconfiginput-conversion-ookuputp
Open

[SLOP(claude-opus-4-8-medium)] fix(rivetkit-wasm): add missing inspector_tabs field to ActorConfigInput conversion#5245
NathanFlurry wants to merge 1 commit into
mainfrom
stack/slop-claude-opus-4-8-medium-fix-rivetkit-wasm-add-missing-inspector_tabs-field-to-actorconfiginput-conversion-ookuputp

Conversation

@NathanFlurry

Copy link
Copy Markdown
Member

No description provided.

…tor_tabs field to ActorConfigInput conversion
@NathanFlurry

NathanFlurry commented Jun 13, 2026

Copy link
Copy Markdown
Member Author

Stack for rivet-dev/rivet

Get stack: forklift get 5245
Push local edits: forklift submit
Merge when ready: forklift merge 5245

@railway-app

railway-app Bot commented Jun 13, 2026

Copy link
Copy Markdown

🚅 Deployed to the rivet-pr-5245 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Jun 14, 2026 at 2:23 am
frontend-cloud 😴 Sleeping (View Logs) Web Jun 14, 2026 at 2:08 am
kitchen-sink ❌ Build Failed (View Logs) Web Jun 13, 2026 at 12:18 am
ladle ✅ Success (View Logs) Web Jun 13, 2026 at 12:14 am
frontend-inspector ❌ Build Failed (View Logs) Web Jun 13, 2026 at 12:12 am
mcp-hub ✅ Success (View Logs) Web Jun 13, 2026 at 12:11 am

@claude

claude Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Code Review

Overview

This PR adds the missing inspector_tabs: None field to the From<WasmActorConfig> for ActorConfigInput conversion in rivetkit-wasm. This is a compile-time fix: inspector_tabs was recently added to ActorConfigInput in rivetkit-core, and the struct literal in the wasm conversion needed to be updated. The fix correctly hard-codes None since custom inspector tabs depend on a PathBuf filesystem root that has no meaning in a browser wasm host.


Correctness

The fix is correct. InspectorTabEntry::Custom carries a root: PathBuf for serving assets from the filesystem — a native/server-only capability. Hard-coding None in the wasm path is the right call. WasmActorConfig intentionally omits an inspector_tabs field, so there is no user-facing regression.

Minor comment precision nit: The comment says the feature "has no meaning in a browser wasm host", which is fully true for Custom tabs. The HideBuiltin variant does not require a filesystem path and could theoretically apply to a wasm host too — but since WasmActorConfig has no field for users to express either variant, None is still the only sensible value. The comment is a small simplification, not a bug.


Pre-existing drift in WasmActorConfig

Unrelated to this PR, WasmActorConfig has several fields that are not forwarded in the From impl:

  • create_state_timeout_ms
  • on_create_timeout_ms
  • on_wake_timeout_ms
  • on_before_actor_start_timeout_ms
  • on_request_timeout_ms

These do not exist on ActorConfigInput, suggesting they were once valid and since removed (or were never in core). Worth tracking as follow-up cleanup to avoid confusion — silently dropping struct fields can mask user config mistakes. Not a blocker for this PR.


Summary

The change is minimal, correct, and follows project conventions. The comment is accurate and readable. No test changes are needed since this is a compile-level fix and the wasm integration suite covers the conversion path.

Verdict: approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant