[SLOP(claude-opus-4-8[1m]-medium)] docs(website): consolidate landing pages, deploy quickstarts, and docs restructuring#5254
Conversation
… pages, deploy quickstarts, and docs restructuring
Review: docs(website) - consolidate landing pages, deploy quickstarts, docs restructuringOverall this is a well-structured refactor. The new icon-grid landing system is clean, the /docs/connect -> /docs/deploy rename makes semantic sense, and redirect coverage looks comprehensive. A few issues worth addressing: Bug: /docs/deploy/rivet-compute is missing connect/rivet-compute.mdx was deleted (changeType: DELETED) but no deploy/rivet-compute.mdx replacement was added. The Deploy landing grid and sidebar both link to /docs/deploy/rivet-compute via deployOptions in deploy.ts (line 45). The redirect in redirects.mjs covers the old URL to the new one, but the target itself would 404. Either recreate the page under deploy/ or remove the Rivet Compute entry from deployOptions. Stale /docs/connect/rivet-compute URLs outside website/src/ These files were not updated:
The redirect handles them at runtime, but they should point to the canonical new path. Security: RIVET_TOKEN in [vars] in cloudflare.mdx The example wrangler.toml in website/src/content/docs/deploy/cloudflare.mdx puts RIVET_TOKEN = "sk_..." under [vars]. Cloudflare [vars] are plaintext bindings visible in the dashboard and potentially in logs. A service key (sk_...) should be set via wrangler secret put RIVET_TOKEN instead. The Supabase guide correctly uses npx supabase secrets set - the Cloudflare guide should match. Minor: isLanding defined but unused website/src/pages/docs/[...slug].astro defines const isLanding = Boolean(landing) but the template uses {landing ? directly. The variable is never referenced. Minor: faSupabase typed as any frontend/packages/shared-data/src/deploy.ts exports faSupabase as any. The explanatory comment is helpful. Tightening to IconDefinition from @fortawesome/fontawesome-common-types would improve downstream type safety, but low priority given the existing as any pattern in the same file. |
No description provided.