Skip to content

[SLOP(claude-opus-4-8[1m]-medium)] docs(website): consolidate landing pages, deploy quickstarts, and docs restructuring#5254

Open
NathanFlurry wants to merge 1 commit into
stack/slop-claude-opus-4-8-refactor-rivetkit-deprecate-actor-kv-api-across-core-and-typescript-polvovvkfrom
stack/slop-claude-opus-4-8-1m-medium-docs-website-consolidate-landing-pages-deploy-quickstarts-and-docs-restructuring-psyxxqon
Open

[SLOP(claude-opus-4-8[1m]-medium)] docs(website): consolidate landing pages, deploy quickstarts, and docs restructuring#5254
NathanFlurry wants to merge 1 commit into
stack/slop-claude-opus-4-8-refactor-rivetkit-deprecate-actor-kv-api-across-core-and-typescript-polvovvkfrom
stack/slop-claude-opus-4-8-1m-medium-docs-website-consolidate-landing-pages-deploy-quickstarts-and-docs-restructuring-psyxxqon

Conversation

@NathanFlurry

Copy link
Copy Markdown
Member

No description provided.

… pages, deploy quickstarts, and docs restructuring
@NathanFlurry

Copy link
Copy Markdown
Member Author

Stack for rivet-dev/rivet

Get stack: forklift get 5254
Push local edits: forklift submit
Merge when ready: forklift merge 5254

@claude

claude Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Review: docs(website) - consolidate landing pages, deploy quickstarts, docs restructuring

Overall this is a well-structured refactor. The new icon-grid landing system is clean, the /docs/connect -> /docs/deploy rename makes semantic sense, and redirect coverage looks comprehensive. A few issues worth addressing:

Bug: /docs/deploy/rivet-compute is missing

connect/rivet-compute.mdx was deleted (changeType: DELETED) but no deploy/rivet-compute.mdx replacement was added. The Deploy landing grid and sidebar both link to /docs/deploy/rivet-compute via deployOptions in deploy.ts (line 45). The redirect in redirects.mjs covers the old URL to the new one, but the target itself would 404. Either recreate the page under deploy/ or remove the Rivet Compute entry from deployOptions.

Stale /docs/connect/rivet-compute URLs outside website/src/

These files were not updated:

  • frontend/src/content/agent-prompts.ts lines 49, 268, 332 still reference /docs/connect/rivet-compute
  • frontend/src/components/use-deployment-logs-stream.ts line 160 uses rivet.dev/docs/connect/rivet-compute

The redirect handles them at runtime, but they should point to the canonical new path.

Security: RIVET_TOKEN in [vars] in cloudflare.mdx

The example wrangler.toml in website/src/content/docs/deploy/cloudflare.mdx puts RIVET_TOKEN = "sk_..." under [vars]. Cloudflare [vars] are plaintext bindings visible in the dashboard and potentially in logs. A service key (sk_...) should be set via wrangler secret put RIVET_TOKEN instead. The Supabase guide correctly uses npx supabase secrets set - the Cloudflare guide should match.

Minor: isLanding defined but unused

website/src/pages/docs/[...slug].astro defines const isLanding = Boolean(landing) but the template uses {landing ? directly. The variable is never referenced.

Minor: faSupabase typed as any

frontend/packages/shared-data/src/deploy.ts exports faSupabase as any. The explanatory comment is helpful. Tightening to IconDefinition from @fortawesome/fontawesome-common-types would improve downstream type safety, but low priority given the existing as any pattern in the same file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant