[SLOP(claude-opus-4-8)] refactor(rivetkit): deprecate actor kv api across core and typescript

[NathanFlurry]

No description provided.

[NathanFlurry]

Stack for rivet-dev/rivet

• [SLOP(gpt-5)] feat(cli): add rivetkit cli #5255 kprpzusk · 2026-06-13 23:00:59
• [SLOP(claude-opus-4-8[1m]-medium)] docs(website): consolidate landing pages, deploy quickstarts, and docs restructuring #5254 psyxxqon · 2026-06-13 23:00:58
• [SLOP(claude-opus-4-8)] refactor(rivetkit): deprecate actor kv api across core and typescript #5253 polvovvk · 2026-06-13 23:00:57 👈
• [SLOP(claude-opus-4-8)] docs(examples): split effect example into hello-world-effect and chat-room-effect #5252 wolqzmyo · 2026-06-13 23:00:56
• [SLOP(gpt-5)] fix(rivetkit): normalize protocol args source-side #5251 lvpxytwl · 2026-06-13 00:10:46
• [SLOP(claude-opus-4-8)] docs(actors): apply docs audit fixes #5250 rtqklwqu · 2026-06-13 00:10:45
• [SLOP(claude-opus-4-8)] docs(actors): rewrite in-memory state page, remove sandbox page, fix stateSaveInterval default, forbid em dashes #5249 pqwwounv · 2026-06-13 00:10:44
• [SLOP(claude-opus-4-8-medium)] docs(pool-configuration): fix runner-config SDK snippet to use RivetClient from engine-api-full #5248 tmoxrznq · 2026-06-13 00:10:42
• [SLOP(claude-opus-4-8-medium)] docs(inspector-tabs): mark illustrative type-shape snippets as @nocheck #5247 yosxkyox · 2026-06-13 00:10:41
• [SLOP(claude-opus-4-8-medium)] docs(quickstart): clean up rust quickstart to import shared actor and auto-download engine #5246 lrzpsprl · 2026-06-13 00:10:40
• [SLOP(claude-opus-4-8-medium)] fix(rivetkit-wasm): add missing inspector_tabs field to ActorConfigInput conversion #5245 ookuputp · 2026-06-13 00:10:39
• main

Get stack: forklift get 5253
Push local edits: forklift submit
Merge when ready: forklift merge 5253

[claude]

Code Review\n\nSummary: Clean, minimal deprecation of the actor KV API across Rust core, the Rust wrapper crate, and the TypeScript package. The approach is solid.\n\n---\n\n### What's working well\n\n- kv_internal() pattern is correct. Adding a pub(crate) accessor so internal engine code (inspector token, actor startup persistence) can continue using KV storage without triggering deprecation warnings is the right approach. The doc comment explaining why it exists is good.\n- All internal call sites updated. The 6 internal kv() to kv_internal() conversions in task.rs and auth.rs are complete.\n- #[allow(deprecated)] in rivetkit/src/context.rs is correct. kv_internal() is pub(crate) in rivetkit-core, so the Rust wrapper crate cannot access it. Calling the deprecated public kv() and suppressing the warning locally is the only option.\n- Both Rust and TypeScript get deprecation markers, which is consistent.\n\n---\n\n### Issues\n\nMinor: inconsistent TypeScript deprecation messages\n\nThe two TypeScript deprecation strings do not match:\n\n- ActorKv interface: Use embedded SQLite (c.db / c.sql) or actor state instead.\n- kv property on ActorContext: Use embedded SQLite (db / sql) or actor state instead.\n\nOne uses the context-prefixed form (c.db) and the other does not. Pick one and use it consistently across both.\n\n---\n\n### Suggestions (non-blocking)\n\n1. Add a comment explaining the #[allow(deprecated)]\n\nThe reason for #[allow(deprecated)] in rivetkit/src/context.rs is not immediately obvious. A one-line comment would clarify that kv_internal() is pub(crate) in rivetkit-core and therefore inaccessible from this crate, making the deprecated public kv() the only viable call target.\n\n2. Docs page should reflect the deprecation\n\nThe sitemap entry for /docs/actors/kv was removed, but the page still exists and is navigable via direct link. Users landing there from search results or old links will not know to migrate. Worth adding a deprecation callout at the top of that page in a follow-up.\n\n3. Test files\n\nAny existing tests that call ctx.kv() directly will now emit deprecation warnings (which is the intent), but they may need #[allow(deprecated)] if CI becomes noisy. Worth a quick scan after this lands.\n\n---\n\n### Verdict\n\nThe core change is correct and complete. Fix the message inconsistency before merging; the rest are suggestions.