Rework #[cold] attribute parser#142491
Merged
bors merged 2 commits intorust-lang:masterfrom Jun 21, 2025
Merged
Conversation
rustbot
added
A-attributes
This was referenced Jun 14, 2025
This comment has been minimized.
This comment has been minimized.
Collaborator
|
☔ The latest upstream changes (presumably #142589) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
jdonszelmann
force-pushed
the
cold
branch
2 times, most recently
from
3db6951 to
414d859
Compare
Collaborator
|
☔ The latest upstream changes (presumably #142697) made this pull request unmergeable. Please resolve the merge conflicts. |
rustbot
added
the
S-waiting-on-review
Collaborator
|
rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi Some changes occurred in compiler/rustc_codegen_ssa |
Contributor
Author
|
@aDotInTheVoid just another version bump of json because another attr changed. I'll consistently do that from now on until I'll fix it properly. I don't mind putting some time in to actually add it to rustdoc proper :) |
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 20, 2025
Rollup of 9 pull requests Successful merges: - #142331 (Add `trim_prefix` and `trim_suffix` methods for both `slice` and `str` types.) - #142491 (Rework #[cold] attribute parser) - #142494 (Fix missing docs in `rustc_attr_parsing`) - #142495 (Better template for `#[repr]` attributes) - #142497 (Fix random failure when JS code is executed when the whole file was not read yet) - #142575 (Ensure copy* intrinsics also perform the static self-init checks) - #142650 (Refactor Translator) - #142713 (mbe: Refactor transcription) - #142755 (rustdoc: Remove `FormatRenderer::cache`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jun 20, 2025
Rollup of 9 pull requests Successful merges: - #142331 (Add `trim_prefix` and `trim_suffix` methods for both `slice` and `str` types.) - #142491 (Rework #[cold] attribute parser) - #142494 (Fix missing docs in `rustc_attr_parsing`) - #142495 (Better template for `#[repr]` attributes) - #142497 (Fix random failure when JS code is executed when the whole file was not read yet) - #142575 (Ensure copy* intrinsics also perform the static self-init checks) - #142650 (Refactor Translator) - #142713 (mbe: Refactor transcription) - #142755 (rustdoc: Remove `FormatRenderer::cache`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 21, 2025
Rollup merge of #142491 - jdonszelmann:cold, r=oli-obk Rework #[cold] attribute parser r? `@oli-obk`
Contributor
What's the issue with attr changes? It's odd to see |
Member
|
Rustdoc JSON includes attributes as strings, and that string representation
is changing in these PRs from "the text you'd see in source code" to
something that looks like `Debug` output of a parsed struct.
This is the least-bad option until we have more specific guarantees about
which attributes have guaranteed representations, and which are best-effort
/ "other".
…On Fri, Jun 20, 2025, 11:55 PM Nicholas Nethercote ***@***.***> wrote:
*nnethercote* left a comment (rust-lang/rust#142491)
<#142491 (comment)>
@aDotInTheVoid <https://github.com/aDotInTheVoid> just another version
bump of json because another attr changed. I'll consistently do that from
now on until I'll fix it properly. I don't mind putting some time in to
actually add it to rustdoc proper :)
What's the issue with attr changes? It's odd to see FORMAT_VERSION change
without any other rustdoc code changing.
—
Reply to this email directly, view it on GitHub
<#142491 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR5MSWFWHCPMPPSLRLZ42T3ETJT3AVCNFSM6AAAAAB7JZ24AWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOJTGMYDCMJVGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
|
@nnethercote effectively that's the problem. We discovered that attributes are put in rustdoc verbatim meaning no rustdoc code has to change and still it's a problem.... We will build a better solution, but I'm afraid it'll take a little bit. |
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jun 23, 2025
Rollup of 9 pull requests Successful merges: - rust-lang/rust#142331 (Add `trim_prefix` and `trim_suffix` methods for both `slice` and `str` types.) - rust-lang/rust#142491 (Rework #[cold] attribute parser) - rust-lang/rust#142494 (Fix missing docs in `rustc_attr_parsing`) - rust-lang/rust#142495 (Better template for `#[repr]` attributes) - rust-lang/rust#142497 (Fix random failure when JS code is executed when the whole file was not read yet) - rust-lang/rust#142575 (Ensure copy* intrinsics also perform the static self-init checks) - rust-lang/rust#142650 (Refactor Translator) - rust-lang/rust#142713 (mbe: Refactor transcription) - rust-lang/rust#142755 (rustdoc: Remove `FormatRenderer::cache`) r? `@ghost` `@rustbot` modify labels: rollup
Member
|
See #141358 for details of what a "better solution" means here, and aDotInTheVoid@9be4e00 for a very WIP implementation |
Member
|
And #142936 for an implementation. |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 24, 2025
…ou, r=GuillaumeGomez rustdoc-json: Add test for `#[cold]` Follow-up to rust-lang#142491 r? `@GuillaumeGomez` CC `@jdonszelmann`
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Jun 26, 2025
Rollup of 9 pull requests Successful merges: - rust-lang/rust#142331 (Add `trim_prefix` and `trim_suffix` methods for both `slice` and `str` types.) - rust-lang/rust#142491 (Rework #[cold] attribute parser) - rust-lang/rust#142494 (Fix missing docs in `rustc_attr_parsing`) - rust-lang/rust#142495 (Better template for `#[repr]` attributes) - rust-lang/rust#142497 (Fix random failure when JS code is executed when the whole file was not read yet) - rust-lang/rust#142575 (Ensure copy* intrinsics also perform the static self-init checks) - rust-lang/rust#142650 (Refactor Translator) - rust-lang/rust#142713 (mbe: Refactor transcription) - rust-lang/rust#142755 (rustdoc: Remove `FormatRenderer::cache`) r? `@ghost` `@rustbot` modify labels: rollup
tautschnig
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Jul 3, 2025
Rollup of 9 pull requests Successful merges: - rust-lang#142331 (Add `trim_prefix` and `trim_suffix` methods for both `slice` and `str` types.) - rust-lang#142491 (Rework #[cold] attribute parser) - rust-lang#142494 (Fix missing docs in `rustc_attr_parsing`) - rust-lang#142495 (Better template for `#[repr]` attributes) - rust-lang#142497 (Fix random failure when JS code is executed when the whole file was not read yet) - rust-lang#142575 (Ensure copy* intrinsics also perform the static self-init checks) - rust-lang#142650 (Refactor Translator) - rust-lang#142713 (mbe: Refactor transcription) - rust-lang#142755 (rustdoc: Remove `FormatRenderer::cache`) r? `@ghost` `@rustbot` modify labels: rollup
mohe2015
pushed a commit
to tucan-plus/rustfmt
that referenced
this pull request
Sep 6, 2025
Rollup of 9 pull requests Successful merges: - rust-lang/rust#142331 (Add `trim_prefix` and `trim_suffix` methods for both `slice` and `str` types.) - rust-lang/rust#142491 (Rework #[cold] attribute parser) - rust-lang/rust#142494 (Fix missing docs in `rustc_attr_parsing`) - rust-lang/rust#142495 (Better template for `#[repr]` attributes) - rust-lang/rust#142497 (Fix random failure when JS code is executed when the whole file was not read yet) - rust-lang/rust#142575 (Ensure copy* intrinsics also perform the static self-init checks) - rust-lang/rust#142650 (Refactor Translator) - rust-lang/rust#142713 (mbe: Refactor transcription) - rust-lang/rust#142755 (rustdoc: Remove `FormatRenderer::cache`) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @oli-obk