Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` by Oneirical · Pull Request #144983 · rust-lang/rust

Oneirical · 2025-08-06T05:01:02Z

Part of #133895

Methodology:

Refer to the previously written tests/ui/SUMMARY.md
Find an appropriate category for the test, using the original issue thread and the test contents.
Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
Rename the tests to make their purpose clearer

Inspired by the methodology that @Kivooeo was using.

r? @jieyouxu

rustbot · 2025-08-06T05:01:07Z

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2025-08-06T05:01:09Z

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

bors · 2025-08-08T10:32:30Z

☔ The latest upstream changes (presumably #145077) made this pull request unmergeable. Please resolve the merge conflicts.

Oneirical · 2025-08-08T21:05:46Z

@rustbot author

rustbot · 2025-08-08T21:05:50Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Oneirical · 2025-08-10T15:57:10Z

@rustbot ready

jieyouxu

Thanks, a few minor issues.

tests/ui/binding/ref-in-function-parameter-patterns-8860.rs

tests/ui/binding/match-with-at-binding-8391.rs

tests/ui/binop/invalid-assignment-lhs-in-while-772182.fixed

tests/ui/binop/invalid-assignment-lhs-in-while-772182.rs

tests/ui/const-generics/invalid-attributes-on-const-params-78957.rs

tests/ui/issues/methods-with-mut-trait-and-polymorphic-objects-issue-8401.rs

tests/ui/modules/module-import-resolution-7663.rs

tests/ui/privacy/inaccessible-fields-pattern-matching-760771.rs

Oneirical · 2025-08-14T02:28:00Z

@rustbot ready

jieyouxu

Thanks

jieyouxu · 2025-08-14T12:01:30Z

@bors r+ rollup

jieyouxu · 2025-08-16T08:59:14Z

Merge conflicts
@bors r-

rustbot · 2025-08-17T03:39:11Z

This PR was rebased onto a different master commit! Check out the changes with our range-diff.

Oneirical · 2025-08-17T17:01:17Z

@rustbot ready

jieyouxu · 2025-08-18T00:56:57Z

@bors r+ rollup

bors · 2025-08-18T00:56:59Z

📌 Commit 75e0263 has been approved by jieyouxu

It is now in the queue for this repository.

…ieyouxu Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` Part of rust-lang#133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer Inspired by the methodology that `@Kivooeo` was using. r? `@jieyouxu`

Rollup of 19 pull requests Successful merges: - #140956 (`impl PartialEq<{str,String}> for {Path,PathBuf}`) - #141744 (Stabilize `ip_from`) - #144804 (Don't warn on never to any `as` casts as unreachable) - #144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #145025 (run spellcheck as a tidy extra check in ci) - #145041 (rework GAT borrowck limitation error) - #145243 (take attr style into account in diagnostics) - #145359 (Fix bug where `rustdoc-js` tester would not pick the right `search.js` file if there is more than one) - #145429 (Couple of codegen_fn_attrs improvements) - #145452 (Do not strip binaries in bootstrap everytime if they are unchanged) - #145486 (Fix `unicode_data.rs` mention message) - #145489 (library: Migrate from `cfg_if` to `cfg_select`) - #145493 (remove `should_render` in `PrintAttribute` derive) - #145500 (Port must_use to the new target checking) - #145505 (Simplify span caches) - #145511 (Rust build fails on OpenBSD after using file_lock feature) - #145516 (Weekly `cargo update`) - #145533 (Reorder `lto` options from most to least optimizing) - #145550 (Avoid using `()` in `derive(From)` output.) r? `@ghost` `@rustbot` modify labels: rollup

…ieyouxu Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` Part of rust-lang#133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer Inspired by the methodology that ``@Kivooeo`` was using. r? ``@jieyouxu``

…ieyouxu Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` Part of rust-lang#133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer Inspired by the methodology that `@Kivooeo` was using. r? `@jieyouxu`

…ieyouxu Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` Part of rust-lang#133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer Inspired by the methodology that ``@Kivooeo`` was using. r? ``@jieyouxu``

Rollup of 33 pull requests Successful merges: - #139345 (Extend `QueryStability` to handle `IntoIterator` implementations) - #140740 (Add `-Zindirect-branch-cs-prefix`) - #142079 (nll-relate: improve hr opaque types support) - #142938 (implement std::fs::set_permissions_nofollow on unix) - #144767 (Correct some grammar in integer documentation) - #144906 (Require approval from t-infra instead of t-release on tier bumps) - #144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #145025 (run spellcheck as a tidy extra check in ci) - #145166 (suggest using `pub(crate)` for E0364) - #145255 (dec2flt: Provide more valid inputs examples) - #145306 (Add tracing to various miscellaneous functions) - #145336 (Hide docs for `core::unicode`) - #145429 (Couple of codegen_fn_attrs improvements) - #145452 (Do not strip binaries in bootstrap everytime if they are unchanged) - #145464 (Stabilize `const_pathbuf_osstring_new` feature) - #145474 (Properly recover from parenthesized use-bounds (precise capturing lists) plus small cleanups) - #145486 (Fix `unicode_data.rs` mention message) - #145493 (remove `should_render` in `PrintAttribute` derive) - #145505 (Simplify span caches) - #145510 (Visit and print async_fut local for async drop.) - #145511 (Rust build fails on OpenBSD after using file_lock feature) - #145532 (resolve: debug for block module) - #145533 (Reorder `lto` options from most to least optimizing) - #145537 (Do not consider a `T: !Sized` candidate to satisfy a `T: !MetaSized` obligation.) - #145538 (bufreader::Buffer::backshift: don't move the uninit bytes) - #145542 (triagebot: Don't warn no-mentions on subtree updates) - #145549 (Update rust maintainers in openharmony.md) - #145550 (Avoid using `()` in `derive(From)` output.) - #145556 (Allow stability attributes on extern crates) - #145560 (Remove unused `PartialOrd`/`Ord` from bootstrap) - #145568 (ignore frontmatters in `TokenStream::new`) - #145571 (remove myself from some adhoc-groups and pings) - #145576 (Add change tracker entry for `--timings`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - #139345 (Extend `QueryStability` to handle `IntoIterator` implementations) - #140740 (Add `-Zindirect-branch-cs-prefix`) - #142079 (nll-relate: improve hr opaque types support) - #142938 (implement std::fs::set_permissions_nofollow on unix) - #143730 (fmt of non-decimal radix untangled) - #144767 (Correct some grammar in integer documentation) - #144906 (Require approval from t-infra instead of t-release on tier bumps) - #144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #145025 (run spellcheck as a tidy extra check in ci) - #145099 (rustc_target: Add the `32s` target feature for LoongArch) - #145166 (suggest using `pub(crate)` for E0364) - #145255 (dec2flt: Provide more valid inputs examples) - #145306 (Add tracing to various miscellaneous functions) - #145336 (Hide docs for `core::unicode`) - #145585 (Miri: fix handling of in-place argument and return place handling) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144983 - Oneirical:uncountable-integer, r=jieyouxu Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` Part of #133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer Inspired by the methodology that ``@Kivooeo`` was using. r? ``@jieyouxu``

Rollup of 15 pull requests Successful merges: - rust-lang#139345 (Extend `QueryStability` to handle `IntoIterator` implementations) - rust-lang#140740 (Add `-Zindirect-branch-cs-prefix`) - rust-lang#142079 (nll-relate: improve hr opaque types support) - rust-lang#142938 (implement std::fs::set_permissions_nofollow on unix) - rust-lang#143730 (fmt of non-decimal radix untangled) - rust-lang#144767 (Correct some grammar in integer documentation) - rust-lang#144906 (Require approval from t-infra instead of t-release on tier bumps) - rust-lang#144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - rust-lang#145025 (run spellcheck as a tidy extra check in ci) - rust-lang#145099 (rustc_target: Add the `32s` target feature for LoongArch) - rust-lang#145166 (suggest using `pub(crate)` for E0364) - rust-lang#145255 (dec2flt: Provide more valid inputs examples) - rust-lang#145306 (Add tracing to various miscellaneous functions) - rust-lang#145336 (Hide docs for `core::unicode`) - rust-lang#145585 (Miri: fix handling of in-place argument and return place handling) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - rust-lang/rust#139345 (Extend `QueryStability` to handle `IntoIterator` implementations) - rust-lang/rust#140740 (Add `-Zindirect-branch-cs-prefix`) - rust-lang/rust#142079 (nll-relate: improve hr opaque types support) - rust-lang/rust#142938 (implement std::fs::set_permissions_nofollow on unix) - rust-lang/rust#143730 (fmt of non-decimal radix untangled) - rust-lang/rust#144767 (Correct some grammar in integer documentation) - rust-lang/rust#144906 (Require approval from t-infra instead of t-release on tier bumps) - rust-lang/rust#144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - rust-lang/rust#145025 (run spellcheck as a tidy extra check in ci) - rust-lang/rust#145099 (rustc_target: Add the `32s` target feature for LoongArch) - rust-lang/rust#145166 (suggest using `pub(crate)` for E0364) - rust-lang/rust#145255 (dec2flt: Provide more valid inputs examples) - rust-lang/rust#145306 (Add tracing to various miscellaneous functions) - rust-lang/rust#145336 (Hide docs for `core::unicode`) - rust-lang/rust#145585 (Miri: fix handling of in-place argument and return place handling) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jieyouxu Aug 6, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 6, 2025

This comment has been minimized.

Sign in to view

jieyouxu added the S-no-work-capacity-tracking Status: Exempted from triagebot work capacity tracking. label Aug 7, 2025

Oneirical force-pushed the uncountable-integer branch 2 times, most recently from bc5adb8 to e74b717 Compare August 8, 2025 19:38

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2025

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 8, 2025

Oneirical force-pushed the uncountable-integer branch from e74b717 to 7690357 Compare August 10, 2025 05:17

This comment has been minimized.

Sign in to view

Oneirical force-pushed the uncountable-integer branch from 7690357 to 742cc39 Compare August 10, 2025 15:57

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 10, 2025

jieyouxu requested changes Aug 12, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2025

Oneirical force-pushed the uncountable-integer branch from 742cc39 to 7afb44a Compare August 14, 2025 00:32

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 14, 2025

jieyouxu approved these changes Aug 14, 2025

View reviewed changes

Oneirical force-pushed the uncountable-integer branch from 7afb44a to f997c37 Compare August 17, 2025 03:39

This comment has been minimized.

Sign in to view

Rehome tests/ui/issues/ tests [5/?]

75e0263

Oneirical force-pushed the uncountable-integer branch from f997c37 to 75e0263 Compare August 17, 2025 17:01

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 17, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2025

Zalathar mentioned this pull request Aug 18, 2025

Rollup of 19 pull requests #145552

Closed

Zalathar mentioned this pull request Aug 18, 2025

Rollup of 18 pull requests #145566

Closed

jhpratt mentioned this pull request Aug 18, 2025

Rollup of 33 pull requests #145588

Closed

This was referenced Aug 19, 2025

Rollup of 17 pull requests #145598

Closed

Rollup of 15 pull requests #145599

Merged

bors merged commit 2d05870 into rust-lang:master Aug 19, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 19, 2025

Uh oh!

Conversation

Oneirical commented Aug 6, 2025

Uh oh!

rustbot commented Aug 6, 2025

Uh oh!

rustbot commented Aug 6, 2025

Uh oh!

This comment has been minimized.

bors commented Aug 8, 2025

Uh oh!

This comment has been minimized.

Oneirical commented Aug 8, 2025

Uh oh!

rustbot commented Aug 8, 2025

Uh oh!

This comment has been minimized.

Oneirical commented Aug 10, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Oneirical commented Aug 14, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Aug 14, 2025

Uh oh!

jieyouxu commented Aug 16, 2025

Uh oh!

rustbot commented Aug 17, 2025

Uh oh!

This comment has been minimized.

Oneirical commented Aug 17, 2025

Uh oh!

jieyouxu commented Aug 18, 2025

Uh oh!

bors commented Aug 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants