add reusable TUI option selector over shared option snapshots by harryalbert · Pull Request #13716 · warpdotdev/warp

harryalbert · 2026-07-14T19:49:35Z

Description

Linked Issue

The linked issue is labeled ready-to-spec or ready-to-implement.
Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

I have manually tested my changes locally with ./script/run

Screenshots / Videos

Agent Mode

Warp Agent Mode - This PR was created via Warp's AI Agent Mode

harryalbert · 2026-07-14T19:49:51Z

add reusable TUI option selector over shared option snapshots #13716 : 2 dependent PRs (#13717 , #13830 ) 👈 (View in Graphite)
add reusable TUI editor view #13817
route TUI editor input by owning-view focus #13771
add option snapshots and adapt GUI orchestration pickers onto them #13714
extract orchestration edit state into a frontend-neutral module #13707
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

oz-for-oss · 2026-07-15T19:03:25Z

@harryalbert

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR adds a reusable headless TUI option selector and generic single-line editor, refactors shared TUI editor keybindings, adds selector/editor render and interaction tests, and documents the as-built design.

Concerns

Custom-text editing can be left in an inconsistent state because selector list navigation still runs while the embedded custom editor is active.
No material security issues were found in the attached diff.
spec_context.md contains no approved or repository spec context, so there was no implementation/spec drift to flag.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

moirahuang · 2026-07-16T17:50:40Z

+                }
+            }
+            TuiOptionSelectorAction::Dismiss => {
+                if !self.handle_back(ctx) {


when do we want to distinguish dismiss vs. escape?

moirahuang · 2026-07-16T17:57:02Z

        KeyCode::PageUp => Some("pageup".to_owned()),
        KeyCode::PageDown => Some("pagedown".to_owned()),
-        KeyCode::Tab | KeyCode::BackTab => Some("\t".to_owned()),
+        KeyCode::Tab | KeyCode::BackTab => Some("tab".to_owned()),


do we need to also update named_control_key_to_c0?

moirahuang · 2026-07-16T18:03:32Z

+- Search and custom text use the shared `TuiEditorView`; printable characters, cursor,
+  selection, single-line paste, horizontal/word/line navigation, undo/redo, and
+  kill/yank come from the shared editor layer. Escape remains host policy with a
+  selector fallback: it clears a non-empty search first, cancels custom editing, or


i think the code does the right behavior of only clearing the non-empty search if it is focused but want to confirm that was your intended flow? if so maybe we can update this spec to be more specific that we clear a non-empty search only if it's focused

Co-Authored-By: Oz <oz-agent@warp.dev>

cla-bot Bot added the cla-signed label Jul 14, 2026

harryalbert mentioned this pull request Jul 14, 2026

extract orchestration edit state into a frontend-neutral module #13707

Merged

2 tasks

This was referenced Jul 14, 2026

add option snapshots and adapt GUI orchestration pickers onto them #13714

Merged

add TUI orchestration permission and configuration card #13717

Open

harryalbert force-pushed the harry/code-1822-option-snapshots branch from 0e8169a to a1da335 Compare July 14, 2026 22:30

harryalbert force-pushed the harry/code-1822-tui-option-selector branch 2 times, most recently from ba49160 to d079c43 Compare July 15, 2026 13:22

harryalbert force-pushed the harry/code-1822-option-snapshots branch 2 times, most recently from 6a11bfe to bf39ff7 Compare July 15, 2026 13:35

harryalbert force-pushed the harry/code-1822-tui-option-selector branch from d079c43 to 891ad83 Compare July 15, 2026 13:35

harryalbert changed the base branch from harry/code-1822-option-snapshots to graphite-base/13716 July 15, 2026 16:33

harryalbert force-pushed the harry/code-1822-tui-option-selector branch from 891ad83 to 8bb2a10 Compare July 15, 2026 16:33

harryalbert changed the base branch from graphite-base/13716 to harry/code-1822-focus-routing July 15, 2026 16:34

harryalbert mentioned this pull request Jul 15, 2026

route TUI editor input by owning-view focus #13771

Merged

2 tasks

harryalbert changed the base branch from harry/code-1822-focus-routing to graphite-base/13716 July 15, 2026 16:34

harryalbert force-pushed the harry/code-1822-tui-option-selector branch from 8bb2a10 to 046ec66 Compare July 15, 2026 16:59

harryalbert force-pushed the graphite-base/13716 branch from a0ee2eb to 1d2cca1 Compare July 15, 2026 16:59

harryalbert changed the base branch from graphite-base/13716 to harry/code-1822-focus-routing July 15, 2026 16:59

This was referenced Jul 15, 2026

add TUI multi-session registry and focused-session root projection #13775

Open

Add local child agents to TUI #13776

Open

rich message component #13777

Open

harryalbert requested a review from moirahuang July 15, 2026 19:03

harryalbert marked this pull request as ready for review July 15, 2026 19:03

oz-for-oss Bot reviewed Jul 15, 2026

View reviewed changes

Comment thread crates/warp_tui/src/option_selector.rs

moirahuang reviewed Jul 16, 2026

View reviewed changes

harryalbert force-pushed the harry/code-1822-focus-routing branch from 1d2cca1 to 991c04e Compare July 16, 2026 02:44

harryalbert force-pushed the harry/code-1822-tui-option-selector branch from 199ce8a to 1e3458b Compare July 16, 2026 02:44

harryalbert requested a review from moirahuang July 16, 2026 03:23

moirahuang reviewed Jul 16, 2026

View reviewed changes

Comment thread crates/warp_tui/src/input/view.rs Outdated

Comment thread crates/warp_tui/src/editor_view.rs Outdated

harryalbert changed the base branch from harry/code-1822-focus-routing to graphite-base/13716 July 16, 2026 11:47

harryalbert force-pushed the harry/code-1822-tui-option-selector branch from d072325 to 6cd77f2 Compare July 16, 2026 11:48

harryalbert changed the base branch from graphite-base/13716 to harry/code-1822-generic-editor-view July 16, 2026 11:48

harryalbert mentioned this pull request Jul 16, 2026

add reusable TUI editor view #13817

Merged

4 tasks

harryalbert requested a review from moirahuang July 16, 2026 11:59

harryalbert force-pushed the harry/code-1822-generic-editor-view branch from a64da86 to db3a140 Compare July 16, 2026 12:44

harryalbert force-pushed the harry/code-1822-tui-option-selector branch from 6cd77f2 to 2920205 Compare July 16, 2026 12:44

harryalbert force-pushed the harry/code-1822-generic-editor-view branch from db3a140 to 9ebd6fb Compare July 16, 2026 12:49

harryalbert force-pushed the harry/code-1822-tui-option-selector branch 2 times, most recently from 57de933 to 1d83418 Compare July 16, 2026 12:53

harryalbert force-pushed the harry/code-1822-generic-editor-view branch from 9ebd6fb to 159290e Compare July 16, 2026 13:56

harryalbert force-pushed the harry/code-1822-tui-option-selector branch 2 times, most recently from b8bfd16 to af6c184 Compare July 16, 2026 14:19

harryalbert force-pushed the harry/code-1822-generic-editor-view branch from 159290e to 6d09be2 Compare July 16, 2026 14:19

moirahuang approved these changes Jul 16, 2026

View reviewed changes

ianhodge mentioned this pull request Jul 16, 2026

Add AskUserQuestion support to the TUI #13830

Open

12 tasks

This was referenced Jul 16, 2026

add reusable TUI tab bar component #13831

Open

Add TUI orchestration tab bar specs #13832

Draft

harryalbert force-pushed the harry/code-1822-tui-option-selector branch from af6c184 to 36b0f8c Compare July 16, 2026 22:12

harryalbert force-pushed the harry/code-1822-generic-editor-view branch from 6d09be2 to bc1a9f3 Compare July 16, 2026 22:12

harryalbert mentioned this pull request Jul 16, 2026

add product and tech spec #13855

Draft

4 tasks

harryalbert force-pushed the harry/code-1822-tui-option-selector branch from 36b0f8c to 1660f1c Compare July 16, 2026 23:09

harryalbert changed the base branch from harry/code-1822-generic-editor-view to graphite-base/13716 July 16, 2026 23:41

add reusable TUI option selector

edc2ee4

Co-Authored-By: Oz <oz-agent@warp.dev>

harryalbert force-pushed the harry/code-1822-tui-option-selector branch from 1660f1c to edc2ee4 Compare July 17, 2026 02:57

harryalbert force-pushed the graphite-base/13716 branch from ee6779e to 1c508d1 Compare July 17, 2026 02:57

harryalbert changed the base branch from graphite-base/13716 to harry/code-1822-generic-editor-view July 17, 2026 02:57

harryalbert changed the base branch from harry/code-1822-generic-editor-view to graphite-base/13716 July 17, 2026 03:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add reusable TUI option selector over shared option snapshots#13716

add reusable TUI option selector over shared option snapshots#13716
harryalbert wants to merge 1 commit into
graphite-base/13716from
harry/code-1822-tui-option-selector

harryalbert commented Jul 14, 2026 •

edited by ianhodge

Loading

Uh oh!

harryalbert commented Jul 14, 2026 •

edited

Loading

Uh oh!

oz-for-oss Bot commented Jul 15, 2026 •

edited

Loading

Uh oh!

oz-for-oss Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moirahuang Jul 16, 2026

Uh oh!

moirahuang Jul 16, 2026

Uh oh!

moirahuang Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

harryalbert commented Jul 14, 2026 • edited by ianhodge Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Linked Issue

Testing

Screenshots / Videos

Agent Mode

Uh oh!

harryalbert commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moirahuang Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

moirahuang Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

moirahuang Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

harryalbert commented Jul 14, 2026 •

edited by ianhodge

Loading

harryalbert commented Jul 14, 2026 •

edited

Loading

oz-for-oss Bot commented Jul 15, 2026 •

edited

Loading