Add AskUserQuestion support to the TUI by ianhodge · Pull Request #13830 · warpdotdev/warp

ianhodge · 2026-07-16T18:03:56Z

Description

Adds an interactive AskUserQuestion tool-call card to the headless TUI. The card shares the questionnaire state machine with the GUI, supports single-select, multiselect, numbered selection, custom “Other” responses, question navigation, and one-press Ctrl+C skip-all behavior. It also restores focus to the main input when the question action finishes and renders deterministic completed-answer summaries.

The implementation is rebased as one commit on harry/code-1822-tui-option-selector (PR #13716) and uses the refreshed generic editor/selector APIs.

Linked Issue

CODE-1846 — Answer questions tool call
The linked issue is ready to implement and is now complete.
End-to-end terminal verification and a rendered TUI snapshot are included below.

Testing

Manually tested locally with ./script/run-tui
cargo nextest run -p warp_tui — 303 passed
cargo nextest run -p ai ask_user_question_session — 17 passed
cargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warnings
cargo clippy -p warp_completer --all-targets --tests -- -D warnings
./script/format --check
./script/check_no_inline_test_modules
git diff --check

Review regressions:

Mixed single-/multi-select payloads retain the original action identity even though the shared session normalizes display order.
Clearing an existing Other response and navigating away removes the stale free-text answer.
Normal option selectors retain their committed selected-row styling independently of ask-question selection ids.
Completed summaries pair normalized questions with finished/API answers by question ID rather than vector position.

Screenshots / Videos

Exact TuiBuffer::to_lines() snapshot asserted by active_card_matches_question_panel_structure:

┌──────────────────────────────────────────────────────────────────────────────┐
│                                                                              │
│ ■ Agent questions                                                 ← 1 of 2 → │
│                                                                              │
│ Which targets should be tested? (select all that apply)                      │
│ (1)   Stable                                                                 │
│ (2)   Nightly                                                                │
│ (3) Other…                                                                   │
│                                                                              │
│ Enter or number to select  Tab or ← → to navigate  Ctrl + C to skip all      │
│                                                                              │
└──────────────────────────────────────────────────────────────────────────────┘

Authenticated real-PTY verification with ./script/run-tui:

Single-select: pressing 2 selected and submitted Option B.
Multiselect: rapid 1, 3, Canary, Enter submitted Stable plus Other: Canary; text did not leak into the main input.
Skip-all: one Ctrl+C skipped all three questions, resumed the model, and kept warp-tui running.

Agent Mode

Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Agent artifacts

CHANGELOG-IMPROVEMENT: Warp's TUI can now answer interactive agent questions, including multiple-choice and custom responses.

Co-Authored-By: Oz oz-agent@warp.dev

oz-for-oss · 2026-07-16T18:04:09Z

@ianhodge

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

ianhodge · 2026-07-16T18:04:27Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Add AskUserQuestion support to the TUI #13830 👈 (View in Graphite)
add reusable TUI option selector over shared option snapshots #13716 : 1 other dependent PR (#13717 )
add reusable TUI editor view #13817
route TUI editor input by owning-view focus #13771
add option snapshots and adapt GUI orchestration pickers onto them #13714
extract orchestration edit state into a frontend-neutral module #13707
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

oz-for-oss

Overview

This PR extracts the AskUserQuestion session state into shared AI code and adds a stateful TUI ask-question card with option-selector integration, keybindings, rendering, and tests.

Concerns

The TUI child view can be recreated repeatedly for mixed single-/multi-select payloads because matches_action compares the session's sorted question order to the original action payload order.
Navigating away from a cleared Other editor can leave the previous free-text answer in the session because blank active text is filtered to None and then not saved.
This is a user-facing TUI change, but the PR description does not include accepted TUI visual evidence. Please attach a terminal transcript, render_to_lines/TuiBuffer::to_lines snapshot diff, or ./script/run-tui capture demonstrating the flow end to end.

Verdict

Found: 0 critical, 3 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

ianhodge · 2026-07-16T18:53:27Z

+
+#[derive(Clone, Debug, Default, Eq, PartialEq)]
+/// In-progress answer data for a single question while the user is editing.
+pub struct QuestionDraft {


agent suggested factoring this out into a seperate file from the view, lmk if you agree with that logic

ianhodge · 2026-07-16T18:56:02Z

/oz-review

oz-for-oss · 2026-07-16T18:56:14Z

@ianhodge

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR adds a shared AskUserQuestion session and wires an interactive AskUserQuestion card into the TUI, including option selection, Other text, navigation, skip-all, focus restoration, and completed summaries.

Concerns

The option selector now ignores its existing selected-row signal outside ask-question cards, which regresses normal option selector rendering for committed selections.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-07-16T19:03:02Z

    ) -> Box<dyn TuiElement> {
        let disabled = row.disabled_reason.is_some();
-        let label_style = if is_selected {
+        let is_selected = self.selected_ids.contains(&row.id);


⚠️ [IMPORTANT] This shadows the is_selected argument with the question-only selected_ids set, which defaults empty for normal option selectors, so existing selectors stop styling their committed selection. Preserve the incoming selected state for non-question selectors, or OR it with self.selected_ids.contains(&row.id).

ianhodge · 2026-07-16T19:24:35Z

Addressed the latest selector-rendering review in 6c13f12. Outside ask-question cards, render_row now explicitly uses the existing selected-row signal; question cards continue to use selected_ids for multiselect state. Added normal_selector_selected_row_does_not_depend_on_question_selected_ids, which verifies the numeric prefix and label retain bold selected styling with empty question ids. Full warp_tui suite: 301/301 passed; both required clippy passes and formatting checks passed.

ianhodge · 2026-07-16T19:24:36Z

/oz-review

oz-for-oss · 2026-07-16T19:24:50Z

@ianhodge

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR adds interactive AskUserQuestion support to the headless TUI, including a shared questionnaire session, TUI question card, option-selector integration, focus restoration, and TUI/unit coverage. The attached TUI snapshot and run-tui transcript satisfy the repo's visual-evidence requirement for this user-facing TUI change. No security findings were identified, and the provided spec context says no approved/repository spec context was found.

Concerns

Completed answer summaries can pair answers with the wrong question when question order differs between the session's normalized editing order and a finished result's action/API order.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-07-16T19:34:02Z

+        let mut content = TuiFlex::column();
+        content.add_child(self.render_summary(&label, answered > 0, app));
+        for (index, question) in self.session.questions().iter().enumerate() {
+            let answer = answers


⚠️ [IMPORTANT] Match answers by question_id here instead of by vector index. AskUserQuestionSession::new sorts questions for editing, but finished results can preserve the original action/API order; with a mixed single-/multi-select payload, answers.get(index) can render an answer beside the wrong question.

Co-Authored-By: Oz <oz-agent@warp.dev>

ianhodge · 2026-07-16T19:48:20Z

/oz-review

oz-for-oss · 2026-07-16T19:48:32Z

@ianhodge

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

Adds a shared AskUserQuestion session state machine and an interactive headless TUI card for answering agent questions, including option selection, custom Other answers, navigation, skip-all behavior, focus restoration, rendered summaries, and regression coverage.

Concerns

No blocking correctness, security, or spec-alignment concerns found in the attached diff. spec_context.md was empty, so there were no approved spec commitments to validate beyond the PR description.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

cla-bot Bot added the cla-signed label Jul 16, 2026

This was referenced Jul 16, 2026

add reusable TUI editor view #13817

Merged

add reusable TUI option selector over shared option snapshots #13716

Open

This was referenced Jul 16, 2026

extract orchestration edit state into a frontend-neutral module #13707

Merged

add option snapshots and adapt GUI orchestration pickers onto them #13714

Merged

harryalbert mentioned this pull request Jul 16, 2026

Add local child agents to TUI #13776

Open

2 tasks

This was referenced Jul 16, 2026

add TUI orchestration permission and configuration card #13717

Open

route TUI editor input by owning-view focus #13771

Merged

add TUI multi-session registry and focused-session root projection #13775

Open

ianhodge mentioned this pull request Jul 16, 2026

rich message component #13777

Open

2 tasks

oz-for-oss Bot reviewed Jul 16, 2026

View reviewed changes

Comment thread crates/warp_tui/src/tui_ask_question_view.rs Outdated

Comment thread crates/warp_tui/src/tui_ask_question_view.rs Outdated

This was referenced Jul 16, 2026

add reusable TUI tab bar component #13831

Open

Add TUI orchestration tab bar specs #13832

Draft

ianhodge commented Jul 16, 2026

View reviewed changes

ianhodge force-pushed the ian/code-1846-answer-questions-tool-call branch from ed4c16c to 8fb7cf0 Compare July 16, 2026 18:54

oz-for-oss Bot reviewed Jul 16, 2026

View reviewed changes

ianhodge force-pushed the ian/code-1846-answer-questions-tool-call branch from 8fb7cf0 to 6c13f12 Compare July 16, 2026 19:23

oz-for-oss Bot reviewed Jul 16, 2026

View reviewed changes

ianhodge requested a review from harryalbert July 16, 2026 19:43

Add AskUserQuestion support to the TUI

6f03d83

Co-Authored-By: Oz <oz-agent@warp.dev>

ianhodge force-pushed the ian/code-1846-answer-questions-tool-call branch from 6c13f12 to 6f03d83 Compare July 16, 2026 19:47

oz-for-oss Bot reviewed Jul 16, 2026

View reviewed changes

harryalbert changed the base branch from harry/code-1822-tui-option-selector to graphite-base/13830 July 16, 2026 22:12

harryalbert mentioned this pull request Jul 16, 2026

add product and tech spec #13855

Draft

4 tasks

Uh oh!

Conversation

ianhodge commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Linked Issue

Testing

Screenshots / Videos

Agent Mode

Agent artifacts

Uh oh!

oz-for-oss Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ianhodge commented Jul 16, 2026

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

Uh oh!

Uh oh!

ianhodge Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

ianhodge commented Jul 16, 2026

Uh oh!

oz-for-oss Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

ianhodge commented Jul 16, 2026

Uh oh!

ianhodge commented Jul 16, 2026

Uh oh!

oz-for-oss Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

ianhodge commented Jul 16, 2026

Uh oh!

oz-for-oss Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ianhodge commented Jul 16, 2026 •

edited

Loading

oz-for-oss Bot commented Jul 16, 2026 •

edited

Loading

oz-for-oss Bot commented Jul 16, 2026 •

edited

Loading

oz-for-oss Bot commented Jul 16, 2026 •

edited

Loading

oz-for-oss Bot commented Jul 16, 2026 •

edited

Loading